search

ACM-IGDTUW / Open-Source-Challenge

Advaya'20 The Open Source Challenge
8 stars 30 forks source link

Betterment of Node Server. #125

Open Omkaragrawal opened 4 years ago

Omkaragrawal commented 4 years ago

I would like to make a few changes to the app.js files, so that the requests made are proper to and fro the node app.

lisa761 commented 4 years ago

Hi, @Omkaragrawal, it would be great if you could explain here the changes you would like to make. In general, wait for your created issues to get a response or some discussion before spending time on a PR in case it is decided to not follow through with it. It will save a lot of your time.

Omkaragrawal commented 4 years ago

Hey @lisa761 , Yep I totally understand.

The changes I made were:

I added a compression module also I added Helmet module to the application.

Since I saw that this project was not equipped with some of the most important requirements, I added them.

soumyaa1804 commented 4 years ago

@Omkaragrawal, it is great that you have the knowledge of these modules but as we do not need to scale this project, we kept it simple and only necessary library and modules are added just to make it work. I don't think adding those changes will have any effect on the project right now.