search

ACM-IGDTUW / Open-Source-Challenge

Advaya'20 The Open Source Challenge
8 stars 30 forks source link

Added GitHub link and removed a broken CSS link #128

Closed Tarster closed 4 years ago

Tarster commented 4 years ago

closes #122
So I had made the necessary changes: 1.) Now only Github Link is there. 2.) I had removed the broken link queryloader.css from the events.ejs file as the file is not present in the location.

lisa761 commented 4 years ago

@Tarster, great work! Have you created an issue for this? If you have then please link this PR to it, or create one and then link this PR. Thanks!

Tarster commented 4 years ago

Hey,I had created a issue but I had closed it.However I had reopened it,so that this PR can be linked to it,However I don't know to link PR with the issue.

lisa761 commented 4 years ago

Edit your description in this PR and add closes #<your-issue-number>.

Tarster commented 4 years ago

Done

soumyaa1804 commented 4 years ago

@Tarster, we have merged the changes for Instagram and LinkedIn icons and they caused merge conflicts in your PR. Nothing to worry! You can resolve them as described here.

Tarster commented 4 years ago

Thanks,I again learned a new thing.By the way,I have removed the merge conflict.

soumyaa1804 commented 4 years ago

Great! PR is good to go now! Cheers!

soumyaa1804 commented 4 years ago

@Tarster, I just noticed that you added the link to this repository instead of the link to our organization ACM-IGDTUW. As this is merged now, I'll create a separate issue for change in URL. If you wish you can solve it. :)