ACM-IGDTUW / Open-Source-Challenge

Advaya'20 The Open Source Challenge
8 stars 30 forks source link

add participant-Niyati #71

Closed niyati-n closed 4 years ago

niyati-n commented 4 years ago

For #20

niyati-n commented 4 years ago

i have updated the changes , you can check now.

lisa761 commented 4 years ago

There seem to be no additional commits in this branch or they would have appeared here. I think you accidentally committed in your master branch. That commit needs to be in this branch for the PR to be merged. It would also be great if you could look up how to delete a pushed commit to remove that commit from master.
You can do this by:

git reset HEAD^--hard
git push origin master --force

Once done, checkout to your current branch of the PR and then make the changes. If you do it on GitHub, make sure you are on this branch and not the master. Have you finished the previous tasks?

niyati-n commented 4 years ago

1 2 3

hey when i change the branch here , i can see the output but after then if open it in a fresh window , the changed branch disappears . i am not able to solve the issue.

niyati-n commented 4 years ago

https://github.com/blackcrabb/Open-Source-Challenge/tree/blackcrabb-task2

soumyaa1804 commented 4 years ago

@blackcrabb can you please attach the output of git branch?

soumyaa1804 commented 4 years ago

i have updated the changes , you can check now.

Did you push them after committing? And did you perform the Task 2 before submitting PR for task 3?

niyati-n commented 4 years ago

I was going through task 2 and was going through some steps and i thought i missed some steps , i tried git fetch upstream and rebase and it added all the members.md i guess

lisa761 commented 4 years ago

That's alright, you just have to remove the dot.

lisa761 commented 4 years ago

Hi @blackcrabb, If you are running into trouble or have a doubt, feel free to ask here.

niyati-n commented 4 years ago

https://github.com/blackcrabb/Open-Source-Challenge/tree/blackcrabb-task2/participants

niyati-n commented 4 years ago

can you please check if i got it this time?

niyati-n commented 4 years ago

Thanks , i can move to Task 3 right

lisa761 commented 4 years ago

Yes, go ahead.