search

ACM-IGDTUW / Open-Source-Challenge

Advaya'20 The Open Source Challenge
8 stars 30 forks source link

add participant-vanshika #90

Closed vkr-code closed 4 years ago

vkr-code commented 4 years ago

Pls suggest changes.. For #50

soumyaa1804 commented 4 years ago

@vkr-code The changes look great but can you make changes to only the file you created in task 2 and delete this file? Your previous file would be vkr-code.md in the participants directory.

vkr-code commented 4 years ago

Okay..thank you...I will do that.

On Thu, 16 Apr, 2020, 1:41 PM Soumya Sharma, notifications@github.com wrote:

@vkr-code https://github.com/vkr-code The changes look great but can you make changes to only the file you created in task 2 and delete this file? Your previous file would be vkr-code.md in the participants directory.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ACM-IGDTUW/Open-Source-Challenge/pull/90#issuecomment-614487758, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOPX45Y2LBL5X4PQ4QK3TYTRM24SXANCNFSM4MJIMLEQ .

lisa761 commented 4 years ago

Hi @vkr-code, just a suggestion, name your PRs in a more appropriate way. For eg, this PR is for Task-3, but your title is the same as that you used for submission of Task-2. You could, for example, name this one as Styling vkr-code.md.

vkr-code commented 4 years ago

Ok,Thank you

On Thu, 16 Apr, 2020, 3:02 PM Lisa Chandra, notifications@github.com wrote:

Hi @vkr-code https://github.com/vkr-code, just a suggestion, name your PRs in a more appropriate way. For eg, this PR is for Task-3 but your title is the same as that you used for submission of Task-2. You could, for example, name this one as Styling vkr-code.md.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ACM-IGDTUW/Open-Source-Challenge/pull/90#issuecomment-614531684, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOPX45775HZB4F4HPREIRFTRM3GCNANCNFSM4MJIMLEQ .

lisa761 commented 4 years ago

Closing this since it has been inactive for a while now. Feel free to reopen in case you want to continue working on this.