search

ACM-VIT / fludget

Learn Flutter on Flutter! A widget directory with implementation samples!
MIT License
31 stars 63 forks source link

Added RotatedBox Widget #241

Closed narayand16 closed 3 years ago

narayand16 commented 3 years ago

PR for issue #235

acmbot[bot] commented 3 years ago

Thanks @narayand16, for opening the pull request! 🙌 One of our team-mates will review the pull request soon. ✅

narayand16 commented 3 years ago

Hi @AryanKhubchandani can you help me in resolving this merge conflict ?

AryanKhubchandani commented 3 years ago

Hi @AryanKhubchandani can you help me in resolving this merge conflict ?

Sure! Run the following lines on command prompt/git/powershell:

Usually running these commands might solve the issue, but if there are still any conflicts in your code, fix them and push the changes. Let me know if you have any doubts.

AryanKhubchandani commented 3 years ago

Also include the screen recording of your work.

narayand16 commented 3 years ago

Also include the screen recording of your work.

  1. quarterTurns = 1

image

  1. quarterTurns = 2

image

  1. quarterTurns = 3

image

  1. quarterTurns = 4

image

Thanks for your guidance !!

narayand16 commented 3 years ago

Hi @AryanKhubchandani can you help me in resolving this merge conflict ?

Sure! Run the following lines on command prompt/git/powershell:

Usually running these commands might solve the issue, but if there are still any conflicts in your code, fix them and push the changes. Let me know if you have any doubts.

Thanks @AryanKhubchandani This has worked

AryanKhubchandani commented 3 years ago

Hi @AryanKhubchandani can you help me in resolving this merge conflict ?

Sure! Run the following lines on command prompt/git/powershell:

Usually running these commands might solve the issue, but if there are still any conflicts in your code, fix them and push the changes. Let me know if you have any doubts.

Thanks @AryanKhubchandani This has worked

No problem!

narayand16 commented 3 years ago

You actually have to show 4 implementations, first with no rotated box, second with quarter turn value: 1, then 2 and finally 3. Please make these changes.

Sure , will do and update the PR

narayand16 commented 3 years ago

You actually have to show 4 implementations, first with no rotated box, second with quarter turn value: 1, then 2 and finally 3. Please make these changes.

Sure , will do and update the PR

Following are the screenshots of implementation:

image

image

image

image

@AryanKhubchandani Kindly review and approve #241

narayand16 commented 3 years ago

Please dont use harcoded color values, instead use ThemeData to define the colors. Also you need to include all four of them in one page. Right now you have included only two implementations. I need you to add rotated box with quarterTurn values 1 and 2 to this page only. Hope you understand and make the changes. Let me know if you have any doubt.

@AryanKhubchandani please look at this screenshot. You were referring to this Theme.of(context).highlightColor when we say using ThemeData to define colors, right?

image

AryanKhubchandani commented 3 years ago

@AryanKhubchandani please look at this screenshot. You were referring to this Theme.of(context).highlightColor when we say using ThemeData to define colors, right?

image

Yeahm I meant that only 😄

acmbot[bot] commented 3 years ago

Congratulations @narayand16, your pull request is merged! 🎉 Thanks for your contributions. 🙌

narayand16 commented 3 years ago

Hi @AryanKhubchandani Thanks for guiding me here. Can you assign me more issues with respect to JavaScript/Angular/HTML, CSS/ Dart technologies? or even your suggestions will also fine

AryanKhubchandani commented 3 years ago

Hi @AryanKhubchandani Thanks for guiding me here. Can you assign me more issues with respect to JavaScript/Angular/HTML, CSS/ Dart technologies? or even your suggestions will also fine

Hey @narayand16! Happy to help you out :) Issues related to Dart open everyday, so keep an eye out for them!