ACM-VIT / fludget

Learn Flutter on Flutter! A widget directory with implementation samples!
MIT License
31 stars 63 forks source link

Added cupertino widgets and improved existing ones. #289

Closed Shah-Aayush closed 2 years ago

Shah-Aayush commented 2 years ago

closes #219

Changes : modified: ios/Podfile.lock modified: lib/routes/Root/rootScreen.dart modified: lib/routes/cupertino_activity_indicator.dart new file: lib/routes/cupertino_alert_dialog.dart new file: lib/routes/cupertino_button.dart new file: lib/routes/cupertino_context_menu.dart new file: lib/routes/cupertino_date_picker.dart new file: lib/routes/cupertino_modal_popup.dart new file: lib/routes/cupertino_popup_surface.dart new file: lib/routes/cupertino_search_field.dart new file: lib/routes/cupertino_sliding_segment_control.dart new file: lib/routes/cupertino_switch.dart new file: lib/routes/cupertino_text_field.dart new file: lib/routes/cupertino_time_picker.dart modified: lib/widgetList.dart modified: pubspec.lock modified: pubspec.yaml

One widget sample :

https://user-images.githubusercontent.com/63921776/138442990-75d1993f-6682-4ebf-ad1d-09af246b795e.mp4

acmbot[bot] commented 2 years ago

Thanks @Shah-Aayush, for opening the pull request! πŸ™Œ One of our team-mates will review the pull request soon. βœ…

Shah-Aayush commented 2 years ago

@AryanKhubchandani Check this out πŸš€

Shah-Aayush commented 2 years ago

Great work on the implementation @Shah-Aayush, but didn't you ask me to add a new tab for Cupertino Widgets? You were supposed to use Cupertino theme there and showcase all the cupertino widgets? Also I don't think we need to include a link to the video as it is already included in the official documentation and there are many widgets which don't have the video link. Since we have made a model for defining parameters in the widgetModel, we cannot have an exception of having buttons for link to videos. Hope you understand.

Yeah sure ! I tried to include all the cupertino widgets in the newly created cupertino tab but I keep getting errors and all so I have included all the widgets in cupertino tag temporarily. I want your help for putting these widgets in cupertino tab. Please include any one sample widget in cupertino tab so that I can follow that and apply for all the cupertino widgets. so I will again open a new issue in which I will put all the cupertino widgets in the cupertino tab.

And for video tutorial, Some people learn very well from visual such as in a video tutorial, while many learn better from reading tutorials. so whenever I find a useful video tutorial regarding any widget, I attached it ! I request you to keep this video button for people like me who can easily grasp concepts through video tutorials. I can also add this button for all the widgets and attach a helpful video tutorial πŸš€

AryanKhubchandani commented 2 years ago

Yeah sure ! I tried to include all the cupertino widgets in the newly created cupertino tab but I keep getting errors and all so I have included all the widgets in cupertino tag temporarily. I want your help for putting these widgets in cupertino tab. Please include any one sample widget in cupertino tab so that I can follow that and apply for all the cupertino widgets. so I will again open a new issue in which I will put all the cupertino widgets in the cupertino tab.

Well, I can add an example afterwards, right now it will be difficult for me as I am busy with some other work. What can be done for now is to remove that section and later see if that feature is needed or not. Earlier you mentioned that you wanted to use Cupertino theme and not Material theme, that's why that section was added. Nevertheless, once the changes required are done, I will merge this PR and open an issue for adding cupertino section in the future.

And for video tutorial, Some people learn very well from visual such as in a video tutorial, while many learn better from reading tutorials. so whenever I find a useful video tutorial regarding any widget, I attached it ! I request you to keep this video button for people like me who can easily grasp concepts through video tutorials. I can also add this button for all the widgets and attach a helpful video tutorial πŸš€

I never said video tutorial won't be helpful, I agree with you in your views. I guess you didn't understand me before, if you open any official documentation, you will find the video you have attached separately already present there. You can easily grasp concepts using the official documentation link only as it has both text and video explanation. In fact, the official documentation even has an interactive sample, which in my opinion is the best way to learn about the widget. Adding a video button is just unnecessary in this case. Let's take an example of the what you have attached in your screen recording only; Check out the official documentation: https://api.flutter.dev/flutter/cupertino/CupertinoActionSheet-class.html. It already has the video you have attached separately. Hope you understand now what I meant before and make the changes.

Shah-Aayush commented 2 years ago

Yes, I understood. I will Remove watch video tutorial from every widget description in the next commit. And for cupertino widget section, Once you implement sample widget then I will add all the remaining widgets in that section. So I am going to open another issue for migrating all cupertino widgets in cupertino tab. I'll work on that after you ping me that you have implemented sample widget in cupertino tab in my next PR πŸš€ Done @AryanKhubchandani ? If Any other suggestions or improvements you have, then let me know :)

AryanKhubchandani commented 2 years ago

Yes, I understood. I will Remove watch video tutorial from every widget description in the next commit. And for cupertino widget section, Once you implement sample widget then I will add all the remaining widgets in that section. So I am going to open another issue for migrating all cupertino widgets in cupertino tab. I'll work on that after you ping me that you have implemented sample widget in cupertino tab in my next PR πŸš€ Done @AryanKhubchandani ? If Any other suggestions or improvements you have, then let me know :)

You don't need to open another issue for that right now as this was the issue in which you were supposed to do that. Let me first do the required work, after that I will open up the issue for you. For now, just make the changes and once I review it, I will merge your PR.

Shah-Aayush commented 2 years ago

Yes, I understood. I will Remove watch video tutorial from every widget description in the next commit. And for cupertino widget section, Once you implement sample widget then I will add all the remaining widgets in that section. So I am going to open another issue for migrating all cupertino widgets in cupertino tab. I'll work on that after you ping me that you have implemented sample widget in cupertino tab in my next PR πŸš€ Done @AryanKhubchandani ? If Any other suggestions or improvements you have, then let me know :)

You don't need to open another issue for that right now as this was the issue in which you were supposed to do that. Let me first do the required work, after that I will open up the issue for you. For now, just make the changes and once I review it, I will merge your PR.

Done all the work @AryanKhubchandani πŸš€

Shah-Aayush commented 2 years ago

Great work @Shah-Aayush! Just one change though, looks like you added SizedOverflowBox twice, please fix that and then I will merge your PR.

@AryanKhubchandani Done βœ…

acmbot[bot] commented 2 years ago

Congratulations @Shah-Aayush, your pull request is merged! πŸŽ‰ Thanks for your contributions. πŸ™Œ