Closed Nix-Naman closed 2 years ago
Thanks @Nix-Naman, for opening the pull request! 🙌 One of our team-mates will review the pull request soon. ✅
@AryanKhubchandani please review my commits.
@AryanKhubchandani hey done with the changes plz check.
Okk
On Mon, Oct 25, 2021, 8:18 PM Aryan Khubchandani @.***> wrote:
@.**** requested changes on this pull request.
Please attach a recording for review. I want to see the changes after the container has been removed.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ACM-VIT/fludget/pull/294#pullrequestreview-788230764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR2AIJJ46RZVLAJVWP5XFD3UIVU3NANCNFSM5GSRUPQA .
@AryanKhubchandani here is the link to the video https://drive.google.com/file/d/13GGhjUw0aqdNTzxTnxgq4J9AgGmwK9ZI/view?usp=drivesdk
@AryanKhubchandani I've alreay resolved all the issues from simple dialog widget with this pull request.
@AryanKhubchandani I've alreay resolved all the issues from simple dialog widget with this pull request.
You didn't, if you are facing any issues I will help you out
You can still see the conflicting files here
In my project I'm not seeing any error and problems its just working pretty fine.
On Wed, Oct 27, 2021, 10:21 AM Aryan Khubchandani @.***> wrote:
@AryanKhubchandani https://github.com/AryanKhubchandani I've alreay resolved all the issues from simple dialog widget with this pull request.
You didn't, if you are facing any issues I will help you out
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ACM-VIT/fludget/pull/294#issuecomment-952536357, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR2AIJJDW3FHMEHM4HXU2YLUI6AMTANCNFSM5GSRUPQA .
I fixed the conflicts.
In my project I'm not seeing any error and problems its just working pretty fine.
Conflicts != errors. Conflicts mean that either you have not synced before pushing changes due to which code in the master branch here is conflicting with your branch or you have made some overlapping changes on code which had been updated before you pulled the code upstream. As mentioned in the README, always sync before you start working on the issue and before you push changes to avoid conflicts. Make it a general practice to do so.
What should i do now , would you please help me.
Congratulations @Nix-Naman, your pull request is merged! 🎉 Thanks for your contributions. 🙌
Fix :Add InteractiveViewer Widget to the Widget Catalog
Recording : https://user-images.githubusercontent.com/74712101/138568251-2745b76f-e66e-43eb-a83b-3de4e7af52dd.mp4