search

ACM-VIT / fludget

Learn Flutter on Flutter! A widget directory with implementation samples!
MIT License
31 stars 63 forks source link

Tooltip feature #296

Closed yuran09 closed 3 years ago

acmbot[bot] commented 3 years ago

Thanks @yuran09, for opening the pull request! 🙌 One of our team-mates will review the pull request soon. ✅

AryanKhubchandani commented 3 years ago

Thanks for fixing the issue @yuran09! Sorry I couldn't respond earlier. Can you please attach screen recording of your work?

yuran09 commented 3 years ago

Thanks for fixing the issue @yuran09! Sorry I couldn't respond earlier. Can you please attach screen recording of your work?

Sure, one minute...

yuran09 commented 3 years ago

Thanks for fixing the issue @yuran09! Sorry I couldn't respond earlier. Can you please attach screen recording of your work?

https://user-images.githubusercontent.com/33298980/138593024-f9f92616-0f88-493a-afbf-ce29ff3ed944.mp4

yuran09 commented 3 years ago

Great job @yuran09! I would suggest not to use Bitcoin's image though, and instead use something more generic as using this image might create copyright issues in the future. Hope you understand my concern and make the changes 😄

Understood, I'll change it

yuran09 commented 3 years ago

@AryanKhubchandani I've done the changes, can you make the merge

acmbot[bot] commented 3 years ago

Congratulations @yuran09, your pull request is merged! 🎉 Thanks for your contributions. 🙌