search

ACM-VIT / fludget

Learn Flutter on Flutter! A widget directory with implementation samples!
MIT License
31 stars 63 forks source link

Remove Original Splash Screen, Removing Error Codes, Upgrade minSdkVersion #304

Closed deltarfd closed 3 years ago

deltarfd commented 3 years ago

Hello, I have been removed the original splash screen from android/app/src/main/res/drawable/splash_grad.xml, android/app/src/main/res/drawable/launch_background.xml, and android/app/src/main/res/layout/splash.xml. In addition, I have removed the code that caused the application error and upgraded the minSdkVersion from 19 to 21. Hope you can review it. Thank You

https://github.com/ACM-VIT/fludget/issues/300

acmbot[bot] commented 3 years ago

Thanks @deltarfd, for opening the pull request! 🙌 One of our team-mates will review the pull request soon. ✅

AryanKhubchandani commented 3 years ago

Hey @deltarfd! I am sorry but I cannot consider this PR as you did not follow the contributing guidelines and opened a PR without being assigned to the issue. The general process is to comment on the issue and ask to get assigned to the issue. Your PR will be considered only if you have been assigned to the issue. Please make sure to follow the guidelines in the future. Hope you understand.

deltarfd commented 3 years ago

Ah okay, no problem and sorry.