search

ACM-VIT / gitpositive

An efficient GitHub profile app, written in Kotlin!
MIT License
15 stars 18 forks source link

Remove Volley and Move the API logic to viewmodel #63

Open rooparsh opened 2 years ago

rooparsh commented 2 years ago

I see that in followers and following screen, the API has been called by Volley library instead of Retrofit being already there. And moreover, the API is being called in UI itself. It's violating the Clean Code architecture.

acmbot[bot] commented 2 years ago

Thanks @rooparsh, for raising the issue! 🙌 One of our team mates will revert on this soon. ✅

rooparsh commented 2 years ago

Please assign this issue to me, will work on it once the PR Link is merged.

acmbot[bot] commented 2 years ago

This issue has been approved by the owner and is open to solve! @rooparsh got 5 points for this issue! 🎉