search

ACMCMU / BoredPrototype

A not-so-boring school project. Original version: http://tinyurl.com/cmuboredcast ... See below for prototype.
http://teudu.herokuapp.com
5 stars 9 forks source link

Home page shows a category "Hot Events". There is no category Hot Events. #33

Closed vivek-pai closed 12 years ago

vivek-pai commented 12 years ago

Maybe change that to "All".

vilcya commented 12 years ago

Sure, I'll try and do that soon. I finished the filtering for events and it's in the branch "Filtering" if you want to look, but if we're using "All", I'll update it.

vivek-pai commented 12 years ago

There's a weird bug in filtering...I added an event in two categories, specifically "Arts" and "Professional".

As I understand it, by default all categories are toggled and that clicking one removes it as a filter. If I remove the "Professional" filter by toggling it, my event disappears, even though it's still attached to the "Arts" filter which is still active. I also can't re-enable a category that I toggled off.

Also, if you don't mind me pushing an update to the css, I might have a better way of tying in the filtering buttons with the overall design.

vilcya commented 12 years ago

Ohh I see... I guess I didn't account for two categories. And sure, go ahead.

vivek-pai commented 12 years ago

Pushed my take of styling - let me know what you think!

vilcya commented 12 years ago

I tried to pull, but got "uninitialized constant ApplicationController::Exceptions." Any ideas?

vivek-pai commented 12 years ago

That's strange...I had changed that out in Master and it's not in the repo (also pulled to the production server and everything is working fine). Maybe it's a merging issue? Alternatively, you can just check out filtering if you didn't make any major changes.

vilcya commented 12 years ago

Since I don't have access, and I need to reinstall Rails again, it seems, could you adjust the min-width size under the html tag to accommodate resizing for the "Create an event" page? Right now if you resize the browser it truncates the header and footer.

Also fixed positioning overlaps with the footer on smaller resize--this isn't a big issue, since people generally won't size their browsers that small except on mobile devices, but just thought I should mention it.

vivek-pai commented 12 years ago

Yeah, I'll do that.

Fixed positioning: I'm getting rid of that since a larger issue is that there won't be any way to view details if the box enlarges past the window.

vivek-pai commented 12 years ago

Should I merge and fix filtering?

vilcya commented 12 years ago

Sorry, I didn't get time to work on it yesterday. I'll work on in today.

vivek-pai commented 12 years ago

Ah, okay. I just wasn't sure if you were able to fix your Rails. Let me know if you run into any issues.

vilcya commented 12 years ago

Filtering should be alright now, it's in the filtering branch. Let me know if there are any bugs.

vivek-pai commented 12 years ago

Alright, just checked it out. There is one bug so far...you can't toggle on/off categories for which there are no events. For example, event A is in category Cultural. Toggle off category Social. Try to toggle Social on again...doesn't work.

vivek-pai commented 12 years ago

On a related note...is "All" supposed to do anything yet?

vilcya commented 12 years ago

This might be a commit problem because I fixed that bug. Also "All" should already work. I'll check if I committed properly (I'm still having a couple issues with my ubuntu and rails)

vivek-pai commented 12 years ago

Never mind, it was on my end...didn't pull.

vivek-pai commented 12 years ago

Cool, works fine for me!

Do you want to just add margin: auto auto; to category-list so that it stays centered?

After that, I think you can just merge it.

vilcya commented 12 years ago

Oh I see, I finally got your style changes .... =/

vivek-pai commented 12 years ago

I'm assuming this is in the event form. I don't see those lines anywhere in that form in master, so it should be like head, no lines.

-Vivek

-----Original Message----- From: vwirantana [mailto:reply@reply.github.com] Sent: Wednesday, April 18, 2012 9:25 PM To: MasterPie Subject: Re: [BoredPrototype] Home page shows a category "Hot Events". There is no category Hot Events. (#33)

I want to make sure I don't merge incorrectly. I have the following, it should remain as the HEAD lines, right?

<<<<<<< HEAD <%= f.label :start_time %> ======= <%= f.label :start_time, 'Start time (EST)' %>

filtering

<<<<<<< HEAD <%= f.label :end_time %> ======= <%= f.label :end_time, 'Start time (EST)' %>

filtering

Reply to this email directly or view it on GitHub: https://github.com/ACMCMU/BoredPrototype/issues/33#issuecomment-5212955

vilcya commented 12 years ago

I want to make sure I don't merge incorrectly. The HEAD lines should remain, is that correct?

<<<<<<< HEAD
            <strong><%= f.label :start_time %></strong>
=======
            <%= f.label :start_time, 'Start time (EST)' %>
>>>>>>> filtering
            <%= text_field_tag 'start_time_date', @event.edit_start_date, :class => 'datepicker' %>
            <%= f.select(:start_time, options_for_select(Event::EVENT_TIMES, closest_half_hour(1))) %>
        </div>

        <div class="field">
<<<<<<< HEAD
            <strong><%= f.label :end_time %></strong>
=======
            <%= f.label :end_time, 'Start time (EST)' %>
>>>>>>> filtering
            <%= text_field_tag 'end_time_date', @event.edit_end_date, :class => 'datepicker' %>
            <%= f.select(:end_time, options_for_select(Event::EVENT_TIMES, closest_half_hour(3))) %>
        </div>
vivek-pai commented 12 years ago

Just merge it so it looks like whatever's in here.

https://github.com/ACMCMU/BoredPrototype/blob/master/app/views/events/_form.html.erb

-----Original Message----- From: vwirantana [mailto:reply@reply.github.com] Sent: Wednesday, April 18, 2012 9:32 PM To: MasterPie Subject: Re: [BoredPrototype] Home page shows a category "Hot Events". There is no category Hot Events. (#33)

I want to make sure I don't merge incorrectly. The HEAD lines should remain, is that correct?

<<<<<<< HEAD
            <strong><%= f.label :start_time %></strong> =======
            <%= f.label :start_time, 'Start time (EST)' %>
>>>>>>> filtering
            <%= text_field_tag 'start_time_date', @event.edit_start_date, :class => 'datepicker' %>
            <%= f.select(:start_time, options_for_select(Event::EVENT_TIMES, closest_half_hour(1))) %>
        </div>

        <div class="field">
<<<<<<< HEAD
            <strong><%= f.label :end_time %></strong> =======
            <%= f.label :end_time, 'Start time (EST)' %>
>>>>>>> filtering
            <%= text_field_tag 'end_time_date', @event.edit_end_date, :class => 'datepicker' %>
            <%= f.select(:end_time, options_for_select(Event::EVENT_TIMES, closest_half_hour(3))) %>
        </div>

Reply to this email directly or view it on GitHub: https://github.com/ACMCMU/BoredPrototype/issues/33#issuecomment-5213038

vilcya commented 12 years ago

Sorry, if you get a chance could you merge the branches? I can't get my local server up so I don't feel comfortable pushing what I have. I've already made all the styling changes in filtering.

vivek-pai commented 12 years ago

Cool, all merged.

Updated Teudu.org

-----Original Message----- From: vwirantana [mailto:reply@reply.github.com] Sent: Thursday, April 19, 2012 3:33 AM To: MasterPie Subject: Re: [BoredPrototype] Home page shows a category "Hot Events". There is no category Hot Events. (#33)

Sorry, if you get a chance could you merge the branches? I can't get my local server up so I don't feel comfortable pushing what I have. I've already made all the styling changes in filtering.

Reply to this email directly or view it on GitHub: https://github.com/ACMCMU/BoredPrototype/issues/33#issuecomment-5216370

vilcya commented 12 years ago

Did the styling get merged? On mine, the categories span two lines on my screen and is still not centered. I pushed the styling on to filtering again just in case.

vivek-pai commented 12 years ago

I did merge it but didn't see the part of your css that you just pushed, so I left whatever I was working with. But yours looks better so I'll merge it again.

-----Original Message----- From: vwirantana [mailto:reply@reply.github.com] Sent: Thursday, April 19, 2012 11:05 AM To: MasterPie Subject: Re: [BoredPrototype] Home page shows a category "Hot Events". There is no category Hot Events. (#33)

Did the styling get merged? On mine, the categories span two lines on my screen and is still not centered. I pushed the styling on to filtering again just in case.

Reply to this email directly or view it on GitHub: https://github.com/ACMCMU/BoredPrototype/issues/33#issuecomment-5223736

vilcya commented 12 years ago

Cool, thanks! I'm going to start adding events.

vivek-pai commented 12 years ago

Hey, I accidentally got rid of the Nick Offerman with Streeter poster....found a bug in that posters don't get saved when you update (unless you upload the poster again). Fixed that bug just now.

Thanks!

-----Original Message----- From: vwirantana [mailto:reply@reply.github.com] Sent: Thursday, April 19, 2012 12:05 PM To: MasterPie Subject: Re: [BoredPrototype] Home page shows a category "Hot Events". There is no category Hot Events. (#33)

Cool, thanks! I'm going to start adding events.

Reply to this email directly or view it on GitHub: https://github.com/ACMCMU/BoredPrototype/issues/33#issuecomment-5225256

vivek-pai commented 12 years ago

Could you later try to make the text color white on hover? I noticed that you are carrying out logic based on the css style (which is why you can't easily make the color white). It's usually better to separate it in model/view. Have a javascript array (the model) of 0s and 1s hold what's on and off and then update the list styles (the view) based on the model. The logic will be much simpler.