[ ] ~Possibly target_time or video_length is a string and not an int~
[x] Add video_length to the debug output for sync drift
Answer: VLC returns the encoded length of the video, not the actual length of the downloaded part of the video. So we can't rely on self.vlc['player'].get_length() to return the value we need.
So let's solve #129 and then this bug will go away.
Details
When the sync server video is longer than the client video, the client keeps skipping rather than ignoring the sync command.
target_timeorvideo_lengthis a string and not an int~video_lengthto the debug output for sync driftAnswer: VLC returns the encoded length of the video, not the actual length of the downloaded part of the video. So we can't rely on
self.vlc['player'].get_length()to return the value we need.So let's solve #129 and then this bug will go away.
Details
When the sync server video is longer than the client video, the client keeps skipping rather than ignoring the sync command.
https://github.com/ACMILabs/media-player/blob/main/media_player.py#L579