#173 Add SYNC_MAX_CLIENTS as an environment variable so that it can be set by XOS - Githubissues

ACMILabs / media-player

A playlist media player prototype.

Mozilla Public License 2.0

12 stars 3 forks source link

#173 Add SYNC_MAX_CLIENTS as an environment variable so that it can be set by XOS #174

Closed sighmon closed 3 years ago

sighmon commented 3 years ago

Resolves #173

Add SYNC_MAX_CLIENTS as an environment variable, so we can set more than 5 media players to sync, and we can also set it in XOS.

Acceptance Criteria

[x] Set SYNC_MAX_CLIENTS as an environment variable defaulting to 5

Relevant design files

None

Testing instructions

Add SYNC_MAX_CLIENTS to a synced media player server, set it to a value and see that that number of clients can still connect to it. Try in s__media-player-pi-4

DoD

For requester to complete:

[x] All acceptance criteria are met
~[ ] New logic has been documented~
~[ ] New logic has appropriate unit tests~
~[ ] Changelog has been updated if necessary~
~[ ] Deployment / migration instruction have been updated if required~