search

ACMNexus / google-collections

Automatically exported from code.google.com/p/google-collections
Apache License 2.0
0 stars 0 forks source link

Release a public AbstractBiMap or BiMaps.newBiMap(Map, Map) method #130

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I think this is one very strong class in the API and you made it package 
viewable only. So I can't for example build a BiMap backed by my own map 
implementations or some standard java impl. like LinkedHashMap for 
insertion-order iteration.

Original issue reported on code.google.com by nimrod.priell on 12 Mar 2009 at 8:19

GoogleCodeExporter commented 8 years ago 
It's always been a future possibility, but designing and documentation for
inheritance is a painful, very time-consuming activity and is not a priority 
for 1.0.

Bear in mind that ImmutableBiMap is insertion-ordered, and that 
insertion-ordered
*mutable* bimaps can be kind of confusing because their key set and value set 
don't
iterate in the corresponding order.

Original comment by kevin...@gmail.com on 12 Mar 2009 at 6:39

GoogleCodeExporter commented 8 years ago 
Instead of making StandardBiMap public, we could instead create a 
BiMaps.newBiMap()
method that takes backing maps as input parameters. That approach avoids 
problems
that arise when collection classes are publicly extendable.

We currently don't have that method because, until now, nobody has asked for it.

Original comment by jared.l....@gmail.com on 12 Mar 2009 at 6:43

GoogleCodeExporter commented 8 years ago 
Actually, we used to have it, for a long time, internally, and then we noticed 
that
of the few people who used it, none of them were actually getting the benefit 
from it
they thought they were.  We decided after giving it a chance that this was not 
very
useful, and we got rid of it.

Original comment by kevin...@gmail.com on 12 Mar 2009 at 6:46

GoogleCodeExporter commented 8 years ago 
Correction: Maps.newBiMap()

Original comment by jared.l....@gmail.com on 12 Mar 2009 at 6:48

GoogleCodeExporter commented 8 years ago

Original comment by kevin...@gmail.com on 12 Sep 2009 at 2:14

GoogleCodeExporter commented 8 years ago 
Issue 235 has been merged into this issue.

Original comment by kevin...@gmail.com on 12 Sep 2009 at 2:15

GoogleCodeExporter commented 8 years ago

Original comment by kevin...@gmail.com on 17 Sep 2009 at 5:45

GoogleCodeExporter commented 8 years ago

Original comment by kevin...@gmail.com on 17 Sep 2009 at 5:57

GoogleCodeExporter commented 8 years ago 
Issue 283 has been merged into this issue.

Original comment by kevin...@gmail.com on 30 Oct 2009 at 4:00

GoogleCodeExporter commented 8 years ago 
This issue has been moved to the Guava project (keeping the same id number). 
Simply replace 'google-collections' with 'guava-libraries' in your address 
bar and it should take you there.

Original comment by kevinb@google.com on 5 Jan 2010 at 11:09