search

ACRA / acra

Application Crash Reports for Android
https://www.acra.ch
Apache License 2.0
6.32k stars 1.14k forks source link

Notification channel sound #1395

Closed ElliotAl86 closed 3 weeks ago

ElliotAl86 commented 1 month ago

Hello. I couldn't find this information anywhere in the documentation, so I'm asking here. Why is the sound for notifications forcibly disabled for a notification channel, regardless of the importance level set for the channel? Is there a reason behind this? If not, it seems it would be useful to have an option in the configuration for this. In general, I would like to be able to use the default notification sound.

F43nd1r commented 1 month ago

Tbh I don't remember why it is that way - maybe to keep consistency with older devices? Or might just be that I hate notification sounds :joy: Did some digging - it has been like this since 2017 https://github.com/ACRA/acra/commit/49812be5ac9431031bb7ee703eaa8f0bb06b434f#diff-d9a3a56280722593595f1cf8bee2221ca10fa85c2ed1132b6fa7b0cb9f5bba45R77

I agree it should be configurable. Actually maybe it'd be best to let the user create the channel, I'm just not sure how to integrate that into the API without breaking changes.

F43nd1r commented 3 weeks ago

v5.12.0 allows you to set up your own notification channel with whatever sound and other options you want - ACRA will not create a the channel in this case.