search

ACRG-Bristol / acrg

Repository containing ACRG analysis code
MIT License
8 stars 0 forks source link

Site will be removed from inversion if it has no data #154

Open wardrebecca opened 1 year ago

wardrebecca commented 1 year ago

In hbmcmc.py after getobs is run any sites without data are removed.

I didn't include amending the input sites in the ini file in case we want to keep the hbmcmc function able to run without an ini file required. At some point something like editing the ini file or including an 'removed_sites' variable in the output file will be required.

Type of Change:

[ ] Bug fix

[X] New feature

[ ] Code-breaking change

Checklist:

[ ] Code documentation has been updated if needed

[ ] If new tests are needed, they have been added

[X] All tests pass

[X] No merge conflicts

[ ] /CHANGELOG.md has been updated if change is significant

Other Comments:

Any additional comments to reviewers not accounted for above

rt17603 commented 10 months ago

This looks fine to me but were we still actively developing the hcmcmc code on acrg? Even if so, is this something we need to raise against the openghg-inversions repository as well?

@rebeccawardbristol Did you still want this code to be merged? Were you able to address the comments above on this?