ACS-Community / ACS-Docker-Image

Docker context for official acs community docker images on https://hub.docker.com/u/acscommunity
MIT License
1 stars 1 forks source link

docker build - warning empty continuation line #18

Open dneise opened 4 years ago

dneise commented 4 years ago

When merging many RUN statements (which is a good thing), we get warning like these:

[WARNING]: Empty continuation line found in:
    RUN yum update -y && yum install -y deltarpm  &&   yum -y update &&   yum -y install epel-release &&   yum -y groupinstall "Development Tools" &&   yum -y install      autoconf      bison      bzip2      bzip2-devel      curl      dos2unix      emacs      epel-release      expat-devel      file      flex      freetype-devel      gcc      gcc-c++      gcc-gfortran      git      git-lfs      java-11-openjdk      java-11-openjdk-devel      ksh      lbzip2      lbzip2-utils      libffi      libffi-devel      libX11-devel      libxml2-devel      libxslt-devel      lockfile-progs      make      mc      nc      net-tools      openldap-devel      openssh-server      openssl-devel      patch      perl      procmail      python-devel      python2-pip      python3-pip      readline-devel      redhat-lsb-core &&      redhat-lsb-core      rpm-build      screen      sqlite-devel      subversion      tcl-devel      tk-devel      tree      unzip      vim      wget      xauth      xterm   && yum clean all
[WARNING]: Empty continuation line found in:
    RUN ln -s /alma/ACS-2020JUN/ACSSW/config/.acs/.bash_profile.acs /alma/.bash_profile &&      groupadd -g 1000 almamgr &&      useradd -g 1000 -u 1000 -d /home/almamgr -m -s /bin/bash almamgr &&      passwd -d almamgr &&      echo "export JAVA_HOME=/usr/lib/jvm/java-11-openjdk-11.0.7.10-4.el7_8.x86_64" >> /home/almamgr/.bashrc &&      echo "source /alma/.bash_profile" >> /home/almamgr/.bashrc
[WARNING]: Empty continuation lines will become errors in a future release.

I think many people would like to be able to have empty lines .. but one person fixed it for the moment, by converting comments into echo statements. This way the comments even show up in the build logs, which might be helpful.

https://github.com/laradock/laradock/issues/1164#issuecomment-452954293

I think I've put too many comments into the Dockerfile anyway..