Do not create user `almamgr` in our image

ACS-Community / ACS-Docker-Image

Docker context for official acs community docker images on https://hub.docker.com/u/acscommunity

MIT License

1 stars 1 forks source link

Do not create user `almamgr` in our image #29

Open dneise opened 4 years ago

dneise commented 4 years ago

I would like to avoid creating the user almamgr in our image. I think user creation should be up the the end-user of our image.

So I would like to remove this: https://github.com/ACS-Community/ACS-Docker-Image/blob/9df3cbd1901147bfc929e2cf2d996060dc392e81/Dockerfile#L117-L124

Reasons:

not everybody might want a user named almamgr
c.f. #23 no everybody might want the user to have UID = 1000
I think it is not needed (I have to check this and provve it to you of course) and what is not needed, should maybe not be in here.

dneise commented 4 years ago

Oh my god .. I just realized I had a bad typo in the title of this issue ... sorry about that.

emiliogq commented 4 years ago

I like this, but I don't know if ACS currently allow us to do so.

May be we can ask in slack- What do you think?

dneise commented 4 years ago

Ah .. so you mean ALMA people want always the almamgr user? So this docker image must contain that user? That is possible...

We can ask in the Slack, sure. But first I want to find the time to make a proposal. And show how it behaves without the almamgr user... maybe I make even a short video or so.

Then we can discuss about a specific proposal. Should make discussions easier

emiliogq commented 4 years ago

I applied the changes in 5d3cbbe

Take a look if you want

@tstaig (in #docker-image slack channel) :

Regarding almamgr user... a simple image can remove it altogether, as you state, everything will work correctly with root The reason I have a specific user is because I usually mount some paths (repositories, data dir, etc.), and I don't like that they get written as root on my host filesystem But that is, as you say, a more advanced use case