ACSVMath / sage_acsv

A SageMath package with algorithms for analytic combinatorics in several variables.
MIT License
3 stars 0 forks source link

Disallowed variable names #17

Open behackl opened 1 week ago

behackl commented 1 week ago

Variables injected by us in the package (in particular: t, lambda_, u_) cannot be used simultaneously as variables in F. For t, this is actually somewhat inconvenient.

A simple solution would be prefixing our variables with some string (acsv_...) -- alternatively, we could make the generation of these structures more intelligent to just automatically avoid this situation.

Maybe we should also just substitute the user-supplied variables with SR.var('x', d) and thus avoid this situation altogether.

smelczer commented 1 week ago

I think we will defer to your greater experience with these kinds of issues and let you pick whichever fix you think is best.

behackl commented 1 week ago

Yeah, I mainly wanted to document this so that we don't forget about it. I'll look into it after we are done with the currently still open updates. 👍