search

ACTCollaboration / actsims

Simulations of the microwave sky as seen by ACT and Planck.
9 stars 4 forks source link

add tiled_noise to seedgen #47

Open zatkins2 opened 3 years ago

zatkins2 commented 3 years ago

This branch adds a single method to the actsims.util _SeedTracker class, for tiled noise sims, as opposed to single-patch noise sims. Besides setting a seed for a tile based on newly relevant data like qid and tile index, it makes two main changes to the class:

  1. Adds self.TILED_NOISE = 6 as an instance variable. This ensures all seeds generated by get_tiled_noise_seed do not overlap with previous noise sims.
  2. Adds 'dr5':3 to self.dmdict. This allows users to pass a DR5 datamodel instance to any of the class methods. The value, 3, is unique, which I think makes sense. However, it does conflict with line 22 of soapack.interfaces: the dict noise_seed_indices, which assigns dr5 to the value 0 -- would argue for this to be changed to 3 as well (if it is referenced?)
zatkins2 commented 3 years ago

Hi Mat, I made a couple changes that should help. The "qid_idx" is now sourced from an additional column in all_arrays_dr5.csv; please see that PR. Also, up to 2 qids can be passed to handle seeds for simulating the correlation of 2 arrays (no more than 2!). Will comment for now and merge once you're able to review the corresponding soapack PR.

msyriac commented 3 years ago

@zatkins2 let's merge this if you think it is up-to-date (confirm and I'll merge)

zatkins2 commented 3 years ago

Hey Mat, thanks for reminding me about this. I think it's slightly out of date with the corresponding PR in soapack, but I'm going to take a look today and probably have only minor modifications to make, will ping you!