search

ACTom / files_mindmap

This application enables Nextcloud users to open, save and edit mind map files in the web browser.
GNU Affero General Public License v3.0
175 stars 48 forks source link

Link shared Mindmap leads to Internal Server error (0.0.22, NC 18.0.6) #122

Open timm2k opened 4 years ago

timm2k commented 4 years ago

Hi @ACTom,

I can't open shared links which points directly to a Mindmap file. Opening such links lead to Internal Server errros.

message":"Exception":"TypeError"
"Message":"substr() expects parameter 3 to be int, bool given"
"Code":0
"Trace":{\"file\":\"/var/www/html/nextcloud/lib/private/Files/Type/Detection.php\",\"line\":377,\"function\":\"substr\",\"args\":[\"mindmap\",0,false]},{\"file\":\"/var/www/html/nextcloud/apps/files_sharing/templates/public.php\",\"line\":22,\"function\":\"mimeTypeIcon\",\"class\":\"OC\\\\Files\\\\Type\\\\Detection\",\"type\":\"->\",\"args\":[\"mindmap\"]},{\"file\":\"/var/www/html/nextcloud/lib/private/Template/Base.php\",\"line\":179,\"args\":[\"/var/www/html/nextcloud/apps/files_sharing/templates/public.php\"],\"function\":\"include\"},{\"file\":\"/var/www/html/nextcloud/lib/private/Template/Base.php\",\"line\":151,\"function\":\"load\",\"class\":\"OC\\\\Template\\\\Base\"
...

I think the mime type detection doesn't work well in 0.0.22 with Nextcloud 18.0.6

I didn't get this error with NC 19.

Can you please fix this?

Kind regards

Timm

timm2k commented 4 years ago

okay, after digging deeper into this the solution is quite easy: nextcloud/core/img/filetypes/mindmap.svg is missing. This is no problem for NC19 but for NC18 it is.

Workaround: cp nextcloud/apps/files_mindmap/img/mindmap.svg nextcloud/core/img/filetypes/mindmap.svg

tt33tt commented 4 years ago

okay, after digging deeper into this the solution is quite easy: nextcloud/core/img/filetypes/mindmap.svg is missing. This is no problem for NC19 but for NC18 it is.

Workaround: cp nextcloud/apps/files_mindmap/img/mindmap.svg nextcloud/core/img/filetypes/mindmap.svg

This helped me!! I needed it although I have NC 19

michel-thomas commented 3 years ago

Same in NC 19.0.3 (upgraded from previous version). Will it be patched in next version of NC?

ACTom commented 3 years ago

Same in NC 19.0.3 (upgraded from previous version). Will it be patched in next version of NC?

I have pushed a pr nextcloud/server#19942 , waiting for merge it.