search

ACTom / files_mindmap

This application enables Nextcloud users to open, save and edit mind map files in the web browser.
GNU Affero General Public License v3.0
174 stars 48 forks source link

Bugfix for Nextcloud 25 #177

Closed msklywenn closed 1 year ago

msklywenn commented 1 year ago

API changed from 24 to 25. This fixes the compatibility issue.

nursoda commented 1 year ago

Would you please add appinfo/info.xml to your PR and set min-version to 22 and max-version to 25 as proposed in the upgrade guide?

msklywenn commented 1 year ago

Will do. I'll also update the version number to 0.0.27 as that probably makes sense. min-version should be 25 though right? I couldn't find when was the API changed but the app worked with nextcloud 24. What would max-version be then? Should I just remove max-version?

nursoda commented 1 year ago

I couldn't find when was the API changed but the app worked with nextcloud 24.

Then at least set it to 24.

What would max-version be then?

I recommend to leave it with 25 as we don't know yet whether there will be breaking changes in 26.

Should I just remove max-version?

No. Both -min and -max need to be there.

nursoda commented 1 year ago

@ACTom your you please merge and release this?

craiq commented 1 year ago

works for me! Thanks

mkrecek234 commented 1 year ago

@ACTom Can you merge this PR please, so we re-establish Nextcloud 25 compatibility? Thank you

ACTom commented 1 year ago

Fixed https://github.com/ACTom/files_mindmap/commit/25ecb0d2dac3d40c49bd6ef9dedca50d9eec38f4