search

ACTtaiwan / CongressionalGuide

Web based look up for U.S. Congress members and candidates to see if they support certain legislation or issues.
MIT License
8 stars 5 forks source link

Primary Election Losers still showing #42

Closed soarhevn closed 8 years ago

soarhevn commented 8 years ago

Candidates who lose in the primary election are still showing in the list. For example, in Washington State 8, only Patty Murray and Chris Vance should show for Senate, and for House, only Dave Reichert & Tony Ventrella should show. For Oregon, only 3 should show for Senate, only 2 should show.

balamark commented 8 years ago

yea, those candidates are the outdated data in the original db. I will add an extra column indicate the candidate source then @terry77228 might need to adjust the front end code a bit.

soarhevn commented 8 years ago

Add field in the DB to show if candidate is a winner of the primary. Field should be called "gen_election_candidate". As long as the field shows if a candidate is a primary winner, then we can use this to show the correct candidates on the front end.

Also need to grab and store in the DB if the candidate is the incumbent [currently import_candidates.py has incumbent=(False,)]

soarhevn commented 8 years ago

Mark, Can you improve the scrappy readme so a new user can understand it. Also perhaps mention it in the STARTHERE.md. Thanks

update: I already did this and will submit a pull request.