search

AChep / AcDisplay

AcDisplay is a new way of handling notifications in Android.
acdisplay.org
GNU General Public License v2.0
750 stars 226 forks source link

Refactor Member Ignoring Method smell in MaterialDialogPreference class #162

Closed emaiannone closed 4 years ago

emaiannone commented 4 years ago

Hi, I'm Emanuele Iannone, a master student at University of Salerno. Since my bachelor's thesis I have been working on a code smell refactoring plugin called aDoctor, which is able to identify and fix energy-related problems in Android apps. I launched it on your project, finding different instances of code smells. I chose one of them and let the plugin automatically fix it. In this case I chose Member Ignoring Method, that is present when a non static method does not use at all instance variables and other non static methods. These kind of smell may have a non trivial impact on energy consumption, as shown in this paper: https://www.sciencedirect.com/science/article/pii/S0950584918301678. Besides, this kind of refactoring does not impact on the functionalities of your app, so it is totally safe. Let me know if you are interested in this refactoring proposal.

AChep commented 4 years ago

Hi,

No, I'm not interested in the "Member Ignoring Method" code smell refactoring. This kind of smell should not affect the performance of the app.

However, other smells from your article are more important. Can you provide a full report?

emaiannone commented 4 years ago

Hi, and thank you for your feedback. You can just type the paper name on Google and you are able to find it without problems.

AChep commented 4 years ago

@emaiannone I'll find the report, or the paper?

emaiannone commented 4 years ago

@AChep The paper