search

AChep / keyguard-app

Keyguard is an alternative client for the Bitwarden® platform, created to provide the best user experience possible.
https://play.google.com/store/apps/details?id=com.artemchep.keyguard
Other
1.15k stars 36 forks source link

Inline Autofill on Samsung #45

Open yurividal opened 9 months ago

yurividal commented 9 months ago

Hi. Thank you for open-sourcing this amazing app. It's beautiful and well designed, and fast. Amazing work.

Have you managed to work arround Samsung's whitelist of PW managers? Could you perhaps distribute a version that uses some whiltelisted package name? (Maybe distribute it on reddit, to avoid any issues here?).

AChep commented 9 months ago

You might want to poke them here https://forum.developer.samsung.com/t/add-keyguard-for-bitwarden-to-a-list-of-autofill-apps/25698

Yeah, I might create a Samsung flavored build.

yurividal commented 8 months ago

I managed to do it myself with this:

I used this tool here: https://github.com/dvaoru/ApkRenamer

I renamed the package to com.agilebits.onepassword (1password) And now autofill works with keypass.

If you want, I can write an "unofficial guide" on keygard reddit page for other people to be able to do it too.

ido1901 commented 8 months ago

It seems to work for me without changing the package name? Latest Samsung Internet (23 something), latest Keyguard, and Swiftkey Keyboard (although I've checked and it shows with Samsung Keyboard as well). Only issue in that in custom tabs (and some other rare occasions) it will send the Samsung Internet package name instead of the current website, thus suggesting only my Samsung Account credentials. But that happens for me also with Bitwarden and with changing the package name to "com.agilebits.onepassword" so I think it's more of a Samsung Internet problem and not Keyguard..

yurividal commented 8 months ago

It seems to work for me without changing the package name? Latest Samsung Internet (23 something), latest Keyguard, and Swiftkey Keyboard (although I've checked and it shows with Samsung Keyboard as well). Only issue in that in custom tabs (and some other rare occasions) it will send the Samsung Internet package name instead of the current website, thus suggesting only my Samsung Account credentials. But that happens for me also with Bitwarden and with changing the package name to "com.agilebits.onepassword" so I think it's more of a Samsung Internet problem and not Keyguard..

Are you sure? Do you get the INLINE autofill? (The one that shows the login button on the keyboard)

ido1901 commented 8 months ago

Yeah. Can't see the Samsung Internet UI on this screenshot, but I promise it is 😅 Keygaurd is latest release from Github. Screenshot_20240121_082920_Samsung Internet

SgtChrischi commented 5 months ago

I managed to do it myself with this:

I used this tool here: https://github.com/dvaoru/ApkRenamer

I renamed the package to com.agilebits.onepassword (1password) And now autofill works with keypass.

If you want, I can write an "unofficial guide" on keygard reddit page for other people to be able to do it too.

Would be nice if you could do that, since its still not working.

yurividal commented 6 days ago

@AChep Seems like the Bitwarden team managed to get the beta app package name whitelisted by Samsung to be used in their browser. Maybe it's worth trying to figure out how they did it in order to get keyguard finally added two Samsungs in line autofill white list.