search

AChep / keyguard-app

Keyguard is an alternative client for the Bitwarden® platform, created to provide the best user experience possible.
https://play.google.com/store/apps/details?id=com.artemchep.keyguard
Other
1.41k stars 41 forks source link

bug: 2fa code on selfhosted can be longer than 6 chars #656

Closed brvn0 closed 1 month ago

brvn0 commented 1 month ago

As title states 2fa codes on selhosted bitwarden instances can be longer than only 6 chars. When putting in a longer 2fa code, the app states they can only be 6 characters long. If I have time I will open a pull request but this will happen at best on Friday this week.

AChep commented 1 month ago

Does Bitwarden allow specifying 2FA length in config somewhere when selfhosting? Could you please point me to an example?

brvn0 commented 1 month ago

Sadly I didn't find - even after half an hour of searching - the relevant lines in config files nor in their docs. But I can send you a config example for vaultwarden (which is an open source, bitwarden compatible server for selfhosting) https://github.com/dani-garcia/vaultwarden/blob/main/.env.template#L468. Even though it isn't the original bitwarden server, I don't think it's wrong to also support vaultwarden since the additional work for allowing longer input in one field in the app is probably minimal.

AChep commented 1 month ago

Fixed by https://github.com/AChep/keyguard-app/commit/a9c369d7f4377cc8abd9dfd0547e9c0cf6959e4b