search

ACloudGuru / dynamodb

27 stars 91 forks source link

A couple of fixes for version 3 of the APK #1

Closed annoyingmouse closed 5 years ago

annoyingmouse commented 9 years ago

Downloading it caused some issues so I guess the new SDK isn't backwards compatible. :-(

I'll work on the waiter when I'm free tomorrow.

annoyingmouse commented 9 years ago

Script now working and generating tables with no errors using the latest AWS SDK for PHP

annoyingmouse commented 9 years ago

uploaddata.php also fixed now

holdorph commented 9 years ago

I don't know php. When I was looking at the differences in these files, I noticed the closing question mark bracket ?> is missing from both files. Is that needed? Is there any harm in it being there?

annoyingmouse commented 8 years ago

Hi @holdorph, the closing "?>" is not required. Please see: http://stackoverflow.com/questions/4410704/why-would-one-omit-the-close-tag

holdorph commented 8 years ago

I'm not a PHP developer, so my apologies. I was basing my comment solely off of the fact that the code this PR was created from was closing the tag.

annoyingmouse commented 8 years ago

Hey @holdorph, don't worry about it! It's always good to ask questions! Take it easy :-)

ghost commented 5 years ago

I fully tested the scripts and they work fine as per the Lab now. Rusty