ACloudGuru / serverless-plugin-aws-alerts

A Serverless Framework plugin that creates CloudWatch alarms for functions.
MIT License
531 stars 149 forks source link

Version is not compliant with semantic versioning #206

Open MHekert opened 2 years ago

MHekert commented 2 years ago

This is a Bug Report

Description

This package has version that is not compliant with semantic versioning. To be compliant with semantic versioning it should not have v prefix in package.json

For bug reports:

For feature proposals:

Similar or dependent issues:

Additional Data

This step in publish workflow config of github actions seems to be an issue:

      - name: Version
        run: yarn version --new-version ${{ github.event.release.tag_name }} --no-git-tag-version --no-commit-hooks

It sets tag name as a version including prefix (v).

Issue with more context about problem created by non semver compliant version number of this package: https://github.com/ds300/patch-package/issues/360