Closed medikoo closed 2 years ago
Can anyone merge this? Is something happening on this front?
I wrote an email to authors of the plugin few days ago, no response so far
@medikoo How did you contact the authors? I don't see anyway to do that.
@disrael I've wrote an email to developers that merged latest changes, and to owners of the package on npm. Still no response unfortunately
👍
Would love to see this merged soon! Patiently waiting, but I'll soon be forced to develop a workaround.
I'll add my plus one to having this merged.
I've just found this plugin in this article and would love to use it with a new project using Serverless v3.
Getting an NPM error and having to track down this PR and then add the --legacy-peer-deps
flag is not a great DX.
+1 we are seeing this error as well with framework v3 would be nice to add the ^2.4.0 || 3
and get this released
Thank you
Because of the way Serverless works, this forces the whole project to downgrade from (global install) v3 to v2 :(
If @shimms isn't available to make a one line change, maybe we need a semi-offical fork ?
So I've messaged an old colleague who works at ACG/Pluralsight to see if he can track down a maintainer.
I've also discovered that with NPM 8 you can add an override in package.json
and then you don't have to add the NPM --legacy-peer-deps
flag.
"overrides":
{
"serverless": "^3.5.1"
}
@jonparker any luck finding the maintainer ?
At what point do plugins get pulled from https://www.serverless.com/plugins?prod_PLUGINS_SEARCH_GROWTH%5Bquery%5D=alert for being unmaintained ?
I've reached out across multiple avenues. The only reply I received was from a sales associate. He told me he would bark up the tree but cautioned me he pulls no weight with product and feature requests. I was also informed that Pluralsight just acquired ACG so if I had to guess they're working through some organizational issues from the acquisition.
No luck yet contacting my previous colleague. But there might be someone else I know who works there.
Hey - let me take a look and find someone here at ACG to help out!!
I've passed this onto our DevOps team to check out as there are some build checks that need to pass first.
Merging #207 (7208147) into master (291c5d7) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #207 +/- ##
=======================================
Coverage 51.53% 51.53%
=======================================
Files 21 21
Lines 522 522
Branches 145 145
=======================================
Hits 269 269
Misses 216 216
Partials 37 37
Thanks everyone! How long until this will be reflected in the NPM package?
Good question. The last version on NPM was released about 6 months ago. The commits to master around that time were by @scub so maybe they can help with publishing to NPM.
Actually I can see that https://www.npmjs.com/~johncmckim published the last version to NPM.
cc: @johncmckim
I'll use "serverless-plugin-aws-alerts": "git://github.com/ACloudGuru/serverless-plugin-aws-alerts.git#6a98d42ab2b1916fb0bdeb31717819575d4e6754"
until there's an official NPM release.
@johncmckim @scub Would you please officially release this on NPM?
Hey folks, sorry for the latency here. I've gone ahead and drafted a new release which includes these changes. It will be versoin 1.7.5 tracking the v1.7.5
release tag. Release notes can be found here
@scub Thank you scub!!
Plugin is confirmed to work with v3 release without issues, therefore it'll be good to whitelist v3 of the Framework in peer dependencies section