search

ACloudGuru / serverless-plugin-cloudwatch-sumologic

Plugin which auto-subscribes a log delivery lambda function to lambda log groups created by serverless
MIT License
12 stars 15 forks source link

Updated the plugin to work with Serverless > 1.25.0 #15

Closed louisnk closed 6 years ago

louisnk commented 6 years ago

Thanks for making a great plugin!

On Serverless 1.25.0 it was failing to add a couple fields to the CF template, which seemed to be required for it to work in my case.

Additionally, my experience showed that the Resource logical IDs needed to be StartCased, so I also updated that, too. It may have been an unnecessary change.

Before these changes, deployment showed my functions sending their logs to the Lambda ARN in the custom block, but logs never showed up in Sumologic. After these changes everything works as expected.

I also added some tests.

GeneralistDev commented 6 years ago

@johncmckim perhaps you could merge this, people are emailing me asking for it.

GeneralistDev commented 6 years ago

Or @Compulsed