search

ADAPT / ISOv4Plugin

Eclipse Public License 1.0
18 stars 35 forks source link

Bin file extensions lowercased to unify approach across solution #130

Closed DmitrySemchenok closed 3 years ago

DmitrySemchenok commented 3 years ago

Bin file extensions unified to prevent bug on linux machines when reading file info with lower case extension nad file has upper case

DmitrySemchenok commented 3 years ago

@knelson-farmbeltnorth please review

knelson-farmbeltnorth commented 3 years ago

@DmitrySemchenok I think this is a reasonable solution given that the code is using lowercase above at line 63.

DmitrySemchenok commented 3 years ago

@knelson-farmbeltnorth Can somebody merge it? Or what the correct process should be?

knelson-farmbeltnorth commented 3 years ago

There is an ADAPT technical committee meeting every other Wednesday that reviews and merges all pull requests. The next one is on 17 February, and we can add it to the agenda. Let me know if you need a patch version release once we merge.

DmitrySemchenok commented 3 years ago

@knelson-farmbeltnorth It would be good to have this patch released as currently in UNIX systems Raster prescriptions can't be exported to IsoXml

knelson-farmbeltnorth commented 3 years ago

@DmitrySemchenok We released a new version yesterday that includes this change.