ADAPT / Standard

ADAPT Standard data model issue management
https://adaptstandard.org
MIT License
7 stars 1 forks source link

Endgun Configuration needs clarifications #15

Closed knelson-farmbeltnorth closed 4 months ago

knelson-farmbeltnorth commented 2 years ago

Within Endgun Table Entry are all values optional? Perhaps throw value is required?

How can the Endgun Configuration have either 1 or multiple table entries. A table entry makes sense in and of itself, but if there are multiples, what is the differentiation in scope of the multiples?

If an Endgun table is just a collection of Endgun Table Entries, why do we need an Endgun table? We can just have the collection of entries.

What is the distinction between members of the Endgun table? There is no logical "primary key," just a collection of values without any scoping information on the values.

knelson-farmbeltnorth commented 2 years ago

Following detailed discussion with @aferreyra, we agreed to rename Endgun Table Entry to Endgun Configuration Record.

Taking the above questions in reverse:

The logical primary key is Pressure. We don't need the Endgun table. We have removed it. The one vs. multiple allows for setting a single default set of values based on one pressure or a more detailed configuration based on multiple pressures. Comments will indicate that only the nominal/default or the collection may be set. We've made all 3 values of the Endgun Configuration Record as required at this time, following cardinality in PAIL.

knelson-farmbeltnorth commented 1 year ago

Changes made in Score

knelson-farmbeltnorth commented 4 months ago

Closing old Irrigation issues. Irrigation was removed from Scope of ADAPT Standard 1.0. We will work through a revised implementation indepedently of what was in the ADAPT Framework.