search

ADAPT / Standard

ADAPT Standard data model issue management
https://adaptstandard.org
MIT License
7 stars 1 forks source link

Elimination of Properties named 1, 2, etc. #17

Open knelson-farmbeltnorth opened 2 years ago

knelson-farmbeltnorth commented 2 years ago

Timescope.Location1 -> StartLocation Timescope.Location2 -> EndLocation

Timescope.Timestamp1 -> Start Timescepe.Timestamp2 -> End

EquipmentConfiguration.Connector1Id -> ActiveConnectorId EquipmentConfiguration.Connector2Id -> PassiveConnectorId

strhea commented 2 years ago

TimeScope was originally designed as an analog to ISO 11783-10 AllocationStamp (ASP) object. ASP has datetime attributes of "start" and "stop" and can include up to 2 position elements meant to also capture "start" and "stop". I think renaming these properties in the ADAPT object is a good idea. Should we consider using "stop" as opposed to "end" ?

AgGateway commented 2 years ago

Food for thought here. No recommendation. With respect to connectors, it seems like there may be three levels (at least). The applicable levels would inform model design.

  1. What two connectors are connected? (this information is required)
  2. What type of connection is made between the two connectors? Is directionality relevant? (e.g., parent/child, superior/subordinate, upstream/downstream)
  3. What role/function is each connector fulfilling in the connection? Is the role/function of each connector dependent on the type of operation being performed using the connected equipment?

Again, food for thought. No response expectations.

knelson-farmbeltnorth commented 2 years ago

4/17/22 meeting agreement on start & end. Re connectors, we will revert to 1 & 2 with comments on use expectation.