ADAPT / Standard

ADAPT Standard data model issue management
https://adaptstandard.org
MIT License
8 stars 1 forks source link

Bounding Box Definition #41

Open knelson-farmbeltnorth opened 2 years ago

knelson-farmbeltnorth commented 2 years ago

Bounding Box MinX, MinY, MaxX and MaxY are currently defined as NumericRepresentationValues. If Point coordinates are always WGS84 and represented as doubles, then BoundingBox should have 4 doubles instead of 4 NRVs and potentially be defined as MinLatitude, MaxLatitude, MinLongitude, MaxLongitude.

aferreyra commented 2 years ago

Your reasoning is sound. Did anyone in recent memory express a need to represent data in UTM (or Gauss-Kruger, etc.) for any reason? That's the only scenario that would justify a NRV.

knelson-farmbeltnorth commented 2 years ago

@aferreyra As geojson does, I think we need to define that any geospatial data in ADAPT is necessarily in EPSG 4326. We discussed this as an unwritten rule in years past. If someone needs to reproject into UTM then they can use the GIS tooling of their choice to do so. Otherwise we are trying to be too many things at once. See my excursus on #44

strhea commented 2 years ago

Agreed. That follows the more widely accepted definition of bounding box. Check the order though.

knelson-farmbeltnorth commented 2 years ago

Discussed at 8/17/22 meeting. We will rename to MinLongitude, etc.