search

ADAPT / Standard

ADAPT Standard data model issue management
https://adaptstandard.org
MIT License
6 stars 0 forks source link

Position & GNSS Source Consistency #96

Open knelson-farmbeltnorth opened 1 year ago

knelson-farmbeltnorth commented 1 year ago

We currently have the following:

Facility.Position.GNSS Source FieldBoundary.GNSSSource GuidancePattern.GNSSSource CropZone.BoundarySource (points to GNSS Source)

GNSS Source contains the signal type, number of satellites, horizontal & vertical accuracy etc.

TimeRecord has a polymorphic Geometry with a simple GNSS Signal Type enum.

I recommend the following for the sake of consistency

  1. Change CropZone.BoundarySource to GNSSSource or FieldBoundary.GNSSSource to BoundarySource
  2. Change Position from a Point to a polymorphic geometry, and replace GNSS Signal Type on TimeRecord with the full Position component. There is otherwise an inconsistency between the detailed GNSS info on boundaries, etc. vs. Time Records.
knelson-farmbeltnorth commented 1 year ago

Agreement in 3 May 2023 meeting to make CropZone & Field Boundary consistent with respect to GNSSSource.

On the second question, we will leave things as is with the exception of omitting GNSS Signal Type on Time Record. This data should be represented with the Logged Data Variables vs. as a fixed property on the object.