ADFC-Hamburg / adfc-ansible

6 stars 2 forks source link

Freifunk exporter #264

Open huckley opened 1 week ago

github-actions[bot] commented 1 week ago

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 2 3.05s
✅ JSON eslint-plugin-jsonc 2 0 0 0.95s
✅ JSON jsonlint 2 0 0.17s
✅ JSON prettier 2 2 0 0.51s
✅ JSON v8r 2 0 2.47s
⚠️ PYTHON bandit 1 1 0.82s
✅ PYTHON black 1 1 0 0.6s
❌ PYTHON flake8 1 3 0.34s
✅ PYTHON isort 1 1 0 0.29s
✅ PYTHON mypy 1 0 8.4s
⚠️ PYTHON pylint 1 2 2.26s
⚠️ PYTHON pyright 1 1 7.57s
❌ PYTHON ruff 1 1 3 0.03s
✅ REPOSITORY dustilock yes no 0.02s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY secretlint yes no 3.12s
✅ REPOSITORY syft yes no 0.37s
⚠️ REPOSITORY trivy yes 1 1.21s
✅ YAML prettier 4 1 0 0.68s
✅ YAML yamllint 4 0 0.24s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

tabacha commented 1 week ago

Ansible-lint meckert auch noch bei diversen Problemen in den neuen Rollen. Ja ich weiß auch die alten haben Probleme, wäre aber schön wenn es nicht immer mehr werden.

qcn[action-core]: Use FQCN for builtin module actions (service).
roles/freifunk_exporter/handlers/main.yml:1 Use `ansible.builtin.service` or `ansible.legacy.service` instead.

name[casing]: All names should start with an uppercase letter.
roles/freifunk_exporter/handlers/main.yml:1 Task/Handler: reload apache

fqcn[action-core]: Use FQCN for builtin module actions (command).
roles/freifunk_exporter/handlers/main.yml:6 Use `ansible.builtin.command` or `ansible.legacy.command` instead.

name[casing]: All names should start with an uppercase letter.
roles/freifunk_exporter/handlers/main.yml:6 Task/Handler: restart prometheus

fqcn[action-core]: Use FQCN for builtin module actions (package).
roles/freifunk_exporter/tasks/main.yml:1 Use `ansible.builtin.package` or `ansible.legacy.package` instead.

name[casing]: All names should start with an uppercase letter.
roles/freifunk_exporter/tasks/main.yml:1 Task/Handler: install python modules

fqcn[action-core]: Use FQCN for builtin module actions (copy).
roles/freifunk_exporter/tasks/main.yml:9 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead.

name[casing]: All names should start with an uppercase letter.
roles/freifunk_exporter/tasks/main.yml:9 Task/Handler: copy python script

yaml[octal-values]: Forbidden implicit octal value "0700"
roles/freifunk_exporter/tasks/main.yml:13

fqcn[action-core]: Use FQCN for builtin module actions (copy).
roles/freifunk_exporter/tasks/main.yml:17 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead.

name[casing]: All names should start with an uppercase letter.
roles/freifunk_exporter/tasks/main.yml:17 Task/Handler: copy the freifunk exporter service

yaml[octal-values]: Forbidden implicit octal value "0644"
roles/freifunk_exporter/tasks/main.yml:21

fqcn[action-core]: Use FQCN for builtin module actions (service).
roles/freifunk_exporter/tasks/main.yml:25 Use `ansible.builtin.service` or `ansible.legacy.service` instead.

yaml[truthy]: Truthy value should be one of [false, true]
roles/freifunk_exporter/tasks/main.yml:29

fqcn[action-core]: Use FQCN for builtin module actions (copy).
roles/freifunk_exporter/tasks/main.yml:31 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead.

yaml[octal-values]: Forbidden implicit octal value "0644"
roles/freifunk_exporter/tasks/main.yml:35

fqcn[action-core]: Use FQCN for builtin module actions (copy).
roles/freifunk_exporter/tasks/main.yml:40 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead.

name[casing]: All names should start with an uppercase letter.
roles/freifunk_exporter/tasks/main.yml:40 Task/Handler: create target for prometheus

yaml[octal-values]: Forbidden implicit octal value "0644"
roles/freifunk_exporter/tasks/main.yml:44

yaml[new-line-at-end-of-file]: No new line character at the end of file
roles/freifunk_exporter/tasks/main.yml:47

fqcn[action-core]: Use FQCN for builtin module actions (service).
roles/fritzbox_exporter_docker/handlers/main.yml:1 Use `ansible.builtin.service` or `ansible.legacy.service` instead.

name[casing]: All names should start with an uppercase letter.
roles/fritzbox_exporter_docker/handlers/main.yml:1 Task/Handler: reload apache

fqcn[action-core]: Use FQCN for builtin module actions (command).
roles/fritzbox_exporter_docker/handlers/main.yml:6 Use `ansible.builtin.command` or `ansible.legacy.command` instead.

name[casing]: All names should start with an uppercase letter.
roles/fritzbox_exporter_docker/handlers/main.yml:6 Task/Handler: restart prometheus

fqcn[action-core]: Use FQCN for builtin module actions (file).
roles/fritzbox_exporter_docker/tasks/main.yml:1 Use `ansible.builtin.file` or `ansible.legacy.file` instead.

yaml[octal-values]: Forbidden implicit octal value "0755"
roles/fritzbox_exporter_docker/tasks/main.yml:5

fqcn[action-core]: Use FQCN for builtin module actions (copy).
roles/fritzbox_exporter_docker/tasks/main.yml:9 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead.

yaml[octal-values]: Forbidden implicit octal value "0644"
roles/fritzbox_exporter_docker/tasks/main.yml:13

fqcn[action-core]: Use FQCN for builtin module actions (file).
roles/fritzbox_exporter_docker/tasks/main.yml:17 Use `ansible.builtin.file` or `ansible.legacy.file` instead.

yaml[octal-values]: Forbidden implicit octal value "0600"
roles/fritzbox_exporter_docker/tasks/main.yml:20

fqcn[action-core]: Use FQCN for builtin module actions (command).
roles/fritzbox_exporter_docker/tasks/main.yml:24 Use `ansible.builtin.command` or `ansible.legacy.command` instead.

name[casing]: All names should start with an uppercase letter.
roles/fritzbox_exporter_docker/tasks/main.yml:24 Task/Handler: docker-compose up shell

fqcn[action-core]: Use FQCN for builtin module actions (copy).
roles/fritzbox_exporter_docker/tasks/main.yml:29 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead.

yaml[octal-values]: Forbidden implicit octal value "0644"
roles/fritzbox_exporter_docker/tasks/main.yml:33

fqcn[action-core]: Use FQCN for builtin module actions (copy).
roles/fritzbox_exporter_docker/tasks/main.yml:38 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead.

name[casing]: All names should start with an uppercase letter.
roles/fritzbox_exporter_docker/tasks/main.yml:38 Task/Handler: create target for prometheus

yaml[octal-values]: Forbidden implicit octal value "0644"
roles/fritzbox_exporter_docker/tasks/main.yml:42

Read documentation for instructions on how to ignore specific rule violations.

                       Rule Violation Summary                        
 count tag                           profile    rule associated tags 
     1 yaml[new-line-at-end-of-file] basic      formatting, yaml     
     9 yaml[octal-values]            basic      formatting, yaml     
     1 yaml[truthy]                  basic      formatting, yaml     
    10 name[casing]                  moderate   idiom                
    16 fqcn[action-core]             production formatting           

Failed: 37 failure(s), 0 warning(s) on 13 files. Last profile that met the validation criteria was 'min'.