search

ADI-Labs / density

wireless density API
13 stars 26 forks source link

Science and Engineering Library? #114

Closed jzf2101 closed 9 years ago

jzf2101 commented 9 years ago

It's listed as being in Mudd, but I believe we're referencing the router in the NoCo Library. We need to confirm and update the data if necessary

blvns commented 9 years ago

This is almost definitely true, since I think the Engineering Library in Mudd was closed for renovations.

jzf2101 commented 9 years ago

We should make this change in the data then I'm going to make a few changes programmatically.

@natebrennand Is there some way we can make a change on the data stream as it comes in to fix this typo? Or can we confirm with CUIT that it's acutally the router from the NoCo Library? If this is some router from Mudd, we probably should know

natebrennand commented 9 years ago

I think there are two steps for resolution.

  1. Update the processor, I can do this part. https://github.com/adicu/wireless_data_processor/blob/master/data.go#L39-L73
  2. Write an update query to run on the current prod database.

(there is an option to just refresh it entirely and skip step 2)

jzf2101 commented 9 years ago

Either could work. we should also confirm with CUIT to confirm the bug since it'd also be an issue on their end too. Do we know who to contact?

On Mar 21, 2015, at 20:12, Nate notifications@github.com wrote:

I think there are two steps for resolution.

1.

Update the processor, I can do this part. https://github.com/adicu/wireless_data_processor/blob/master/data.go#L39-L73 2.

Write an update query to run on the current prod database.

(there is an option to just refresh it entirely and skip step 2)

— Reply to this email directly or view it on GitHub https://github.com/adicu/density/issues/114#issuecomment-84477758.

natebrennand commented 9 years ago

Generally I don't think getting CUIT to alter it is worthwhile given how troubling it would be. If you really do want to get it changed @rbtying is the POC.

jzf2101 commented 9 years ago

@rbtying it might be good for us to confirm which router it is before we change anything?

rbtying commented 9 years ago

I believe it's NWC. but I can reach out and check?

jzf2101 commented 9 years ago

Yeah I think so too, I just would prefer not to change the names twice

jzf2101 commented 9 years ago

@rbtying bumping this again now that we have the map feature out - any news?

jzf2101 commented 9 years ago

@natebrennand so we're pretty sure this is NoCo could you update the processor part to fix the data

natebrennand commented 9 years ago

Would you mind opening an issue here with exactly what you want it to be called? Also, do you want me to backfill the database?

jzf2101 commented 9 years ago

@natebrennand thanx I'll make that into an issue also it should be corrected for the whole db

jzf2101 commented 9 years ago

@evantarrh map lists the library as noco - could we reflect this change?

jzf2101 commented 9 years ago

I suggest renaming this to "Northwest Corner Building"

jzf2101 commented 9 years ago

@natebrennand We're good to close this now?

natebrennand commented 9 years ago

no, this will be closed when the data dump has been updated.