search

ADI-Labs / density

wireless density API
13 stars 26 forks source link

Only show alert for the map once #156

Closed evantarrh closed 9 years ago

evantarrh commented 9 years ago

review: @natebrennand @RaymondXu @jzf2101

after the first visit to the site, a cookie is set so that the map alert is not shown on capacity.html

closes #153!

natebrennand commented 9 years ago

This looks like it will work fine. However, I don't totally see how it's necessary and I also think it should just be in JS if it is.

evantarrh commented 9 years ago

hmm okay! how would you do this in JS without cookies? or would it be better to not do this at all and always promote the map feature?

natebrennand commented 9 years ago

You'd still use cookies, this just seems like something that shouldn't be server-side to me. I generally think that the API and the website should be in separate repositories.

evantarrh commented 9 years ago

actually i think you are right after discussing with the team––people would be more likely to just miss it and not pay attention.

closing this PR!