search

ADI-Labs / density

wireless density API
13 stars 26 forks source link

Docker and Consul support #158

Closed thebrianzeng closed 9 years ago

thebrianzeng commented 9 years ago

@natebrennand

Modified @natebrennand's pull request.

jzf2101 commented 9 years ago

:+1: when tests pass

thebrianzeng commented 9 years ago

@thenatebrennand how did you get your build for the encoder to pass? i keep getting density/config/flask_config.py:90:1: E402 module level import not at top of file density/density.py:16:1: E402 module level import not at top of file and so on

natebrennand commented 9 years ago

I'm guessing travis wasn't setup properly then. I would just move the import to the top. Make sure you delete your editor file that's in the PR right now.

thebrianzeng commented 9 years ago

@natebrennand any other comments before we merge this?

natebrennand commented 9 years ago

Should we switch it to trigger env vars on USE_ENV_VARS like in adi-website?

thebrianzeng commented 9 years ago

added that functionality

On Fri, Apr 24, 2015 at 2:35 PM Nate notifications@github.com wrote:

Should we switch it to trigger env vars on USE_ENV_VARS like in adi-website?

— Reply to this email directly or view it on GitHub https://github.com/adicu/density/pull/158#issuecomment-96027234.

jzf2101 commented 9 years ago

Alternatively, we could build a hardcode solution to avoid @swbae31 's requests issue for now