search

ADI-Labs / density

wireless density API
13 stars 26 forks source link

Kill Consul #193

Closed alanhdu closed 8 years ago

alanhdu commented 8 years ago

Close #181

alanhdu commented 8 years ago

@danrschlosser @thebrianzeng Look good? How are we going to deploy Density w/o Consul?

For review: this is actually two related changes (kills Consul, but also fixes some Vagrant issues on Windows).

alanhdu commented 8 years ago

@danrschlosser @thebrianzeng Thoughts? If there are no comments, I'll merge this tonight.

schlosser commented 8 years ago

This looks solid to me, sorry for letting it slip through the cracks

alanhdu commented 8 years ago

So, the mail password seems to only live on Consul. When we get closer to deploying a new version, I can rewrite it so that it loads this stuff from an environment variable.