search

ADLINK-IST / opensplice

This is the Vortex OpenSplice Community Edition source repository. For our commercial offering see
https://www.adlinktech.com/en/vortex-opensplice-data-distribution-service
Apache License 2.0
259 stars 157 forks source link

VS2017 TDataReaderImpl.hpp Argument conversion warning #69

Open HarryDC opened 5 years ago

HarryDC commented 5 years ago

Visual studio 2017 64bit target gives a warning about a conversion from size_t to os_uint32. for line 616: 

    u_dataReader uReader = u_dataReaderNew(uSubscriber, name.c_str(), expression.c_str(),
        params.empty() ? NULL : &params[0], params.size(), uQos);

This is in the current master. The latest public downloadable binary version does not show this warning

HarryDC commented 5 years ago

Another conversion warning in \HDE\x86_64.win64\include\dcps\C++\isocpp2\dds\topic\detail\ContentFilteredTopic.hpp line 121

        if (!u_topicContentFilterValidate2(uTopic, expr, params.empty() ? NULL : &params[0], params.size())) {
HarryDC commented 5 years ago

Is an explicit cast to os_uint32 a valid solution for this ?

ThijsSassen commented 5 years ago

@HarryDC for now thats a valid solution we will look into a fix for this in a future version