ADLINK-IST / opensplice

This is the Vortex OpenSplice Community Edition source repository. For our commercial offering see
https://www.adlinktech.com/en/vortex-opensplice-data-distribution-service
Apache License 2.0
259 stars 157 forks source link

xtypes/TypeKind.hpp type typo in isocpp interfaces #70

Closed joakimono closed 5 years ago

joakimono commented 6 years ago

When trying to use the xtypes interface of isocpp or isocpp2 we get an compilation error. enum type should be enum Type in the TypeKind_def struct of both isocpp and isocpp2:

As an example the dds::core::safe_enum in SafeEnumeration.hpp expects the second template type to be def::Type with a capital T, not def::type.

We are currently patching this with the following command: sed -i 's|enum type|enum Type|' src/api/dcps/{isocpp/include/spec,isocpp2/include}/dds/core/xtypes/TypeKind.hpp

hansvanthag commented 6 years ago

Xtypes isn't supported in OpenSplice, however we do support Google-protocol-buffers which also offers an extensible data-model (and is widely known/recognized)

joakimono commented 6 years ago

I understand, but we use those header files in our implementation with types support. It would simply be nice to not having to patch the errors whenever we compile opensplice for use in our libraries.

b3em commented 5 years ago

Fixed by 339f1015cba2cef839b56cbdca64ab2308f81f08