jeremytammik
commented
3 years ago Looks good at first glance. Thank you very much!
Closed Naveen-Kumar-Thalaivirichan closed 3 years ago
jeremytammik
commented
3 years ago Looks good at first glance. Thank you very much!
jeremytammik
commented
3 years ago You apparently only updated the references in IntroCs and IntroVb. I had to update the API references in FamilyCs, FamilyVb, UiCs and UiVb to Revit 2022 myself.
jeremytammik
commented
3 years ago There is still a lot of deprecated API usage in here, cf. attached text file:
revit_2022_training_material_migration.txt
would you like to fix that?
thank you!
jeremytammik
commented
3 years ago I integrated this pull request into release 2022.0.0.0: https://github.com/ADN-DevTech/RevitTrainingMaterial/releases/tag/2022.0.0.0
we'll need another update to fix the deprecated api usage.
jeremytammik
commented
3 years ago Hi Team,
User @NK29 submitted a pull request #10 for RevitTrainingMaterial Revit 2022 Migration:
https://github.com/ADN-DevTech/RevitTrainingMaterial/pull/10
I assume that was you Naveen?
Thank you very much for that effort.
I appears that you only updated the Revit API references in ther two projects IntroCs and IntroVb.
I updated in four more myself: FamilyCs, FamilyVb, UiCs and UiVb to Revit 2022.
After that flat migration, there remains a lot of deprecated API usage, cf. attached text file:
revit_2022_training_material_migration.txt
would you like to fix that as well?
thank you!
I integrated this pull request into an initial flat migration release 2022.0.0.0:
https://github.com/ADN-DevTech/RevitTrainingMaterial/releases/tag/2022.0.0.0
We'll need another update to fix the deprecated api usage.
cheers,
jeremy
From: NK29 @.> Reply to: ADN-DevTech/RevitTrainingMaterial @.> Date: Friday, 30 April 2021 at 10:07 To: ADN-DevTech/RevitTrainingMaterial @.> Cc: Subscribed @.> Subject: [ADN-DevTech/RevitTrainingMaterial] Revit 2022 Migration (#10)
Updated LAB Samples to Revit 2022
You can view, comment on, or merge this pull request online at:
https://github.com/ADN-DevTech/RevitTrainingMaterial/pull/10https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FADN-DevTech%2FRevitTrainingMaterial%2Fpull%2F10&data=04%7C01%7Cjeremy.tammik%40autodesk.com%7C984922b25ddd4dcbb7a508d90baefabd%7C67bff79e7f914433a8e5c9252d2ddc1d%7C0%7C0%7C637553668435545311%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=9%2Bh1wiZPpOKL0PRsErfLyTcLmBfJuugGI1hkrkGiSfY%3D&reserved=0
Commit Summary
File Changes
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FADN-DevTech%2FRevitTrainingMaterial%2Fpull%2F10&data=04%7C01%7Cjeremy.tammik%40autodesk.com%7C984922b25ddd4dcbb7a508d90baefabd%7C67bff79e7f914433a8e5c9252d2ddc1d%7C0%7C0%7C637553668435995111%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=YyevJ%2BRku1h1j1ZvoDpom5DhsPFPI9ATf5XMDu9f9aY%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABARFDPU5S44CCN53NTKVQTTLJQLNANCNFSM433V7M6Q&data=04%7C01%7Cjeremy.tammik%40autodesk.com%7C984922b25ddd4dcbb7a508d90baefabd%7C67bff79e7f914433a8e5c9252d2ddc1d%7C0%7C0%7C637553668436005104%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2FvGD1roHXbFZK%2FgOlan8dyIKvNCPqkm33rAK5%2B3fgaw%3D&reserved=0.
Updated LAB Samples to Revit 2022