ADORSYS-GIS / e2e-banking-app

Banking app for people
https://adorsys-gis.github.io/e2e-banking-app/
Mozilla Public License 2.0
4 stars 21 forks source link

Update the OKPage.tsx file. #117

Closed Ogenbertrand closed 4 months ago

Ogenbertrand commented 4 months ago

@stephane-segning Please review my PR. fix the build error in the main

Ogenbertrand commented 4 months ago

@stephane-segning

The ticket's name is fea/service worker, but where is it?

Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR.

Ogenbertrand commented 4 months ago

@stephane-segning

The ticket's name is fea/service worker, but where is it?

Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR.

After creating the new PR from the main branch it happened that my commits weren't verified so my work couldn't be merged what i did is i undo all the commits from the PR closed it and created another PR which is this one

Motouom commented 4 months ago

The ticket's name is fea/service worker, but where is it?

Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR.

After creating the new PR from the main branch it happened that my commits weren't verified so my work couldn't be merged what i did is i undo all the commits from the PR closed it and created another PR which is this one

@Ogenbertrand tag @stephane-segning when you are writing a comment if not, he won't see it

stephane-segning commented 4 months ago

The ticket's name is fea/service worker, but where is it?

Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR.

After creating the new PR from the main branch it happened that my commits weren't verified so my work couldn't be merged what i did is i undo all the commits from the PR closed it and created another PR which is this one

It's a nice story but not interesting @Ogenbertrand. This PR is created under a specific name. But that name does not match the implementation. Try fixing that

Ogenbertrand commented 4 months ago

The ticket's name is fea/service worker, but where is it?

Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR.

After creating the new PR from the main branch it happened that my commits weren't verified so my work couldn't be merged what i did is i undo all the commits from the PR closed it and created another PR which is this one

It's a nice story but not interesting @Ogenbertrand. This PR is created under a specific name. But that name does not match the implementation. Try fixing that

Okay sir @stephane-segning. I just fixed it

stephane-segning commented 4 months ago

The ticket's name is fea/service worker, but where is it?

Hello sir the fea/service worker branch was merged in the main branch already, after the the merging was done it happened that one test was failing from the main branch which is the "build test". So what i did was i navigated to the main branch and started debugging from there which i ended up fixing the fault and i created a new PR.

After creating the new PR from the main branch it happened that my commits weren't verified so my work couldn't be merged what i did is i undo all the commits from the PR closed it and created another PR which is this one

It's a nice story but not interesting @Ogenbertrand. This PR is created under a specific name. But that name does not match the implementation. Try fixing that

Okay sir @stephane-segning. I just fixed it

Then what are you updating here?

Ogenbertrand commented 4 months ago

@stephane-segning I Renamed the component OKpage to OKPage to maintain consistency, Called the sendMoney() function within the useEffect() hook to trigger the API call when the component mounts, Modified the component name in the export statement to match the component's name (OKPage). Refactor OKPage component and fix API call