search

ADORSYS-GIS / report-sscrap

0 stars 0 forks source link

feature(backend)added intergration with analysis script #109

Closed ValantineSuh closed 10 months ago

ValantineSuh commented 10 months ago

added functionality on integrating database with analysis script

ValantineSuh commented 10 months ago

hello @stephane-segning all resolved sir and linked to the database storage functionality

AssahBismarkabah commented 10 months ago

all good sir @stephane-segning

AssahBismarkabah commented 10 months ago

good morning sir @ArmandMeppa thank you sir for the review we will adjust that as soon as possible

ValantineSuh commented 10 months ago

Good Morning Sir @ArmandMeppa Thank you fo the review. We will do the necessary adjustments today

On Thu, Nov 30, 2023, 14:32 AssahBismarkabah @.***> wrote:

all good sir @stephane-segning https://github.com/stephane-segning

— Reply to this email directly, view it on GitHub https://github.com/ADORSYS-GIS/report-sscrap/pull/109#issuecomment-1833792607, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDOOSXJ4SIGUPLOHJVQWKC3YHCDGLAVCNFSM6AAAAABABGCIVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZTG44TENRQG4 . You are receiving this because you were assigned.Message ID: @.***>

AssahBismarkabah commented 10 months ago

updated sir

On Thu, Nov 30, 2023 at 3:09 PM Stephane SEGNING LAMBOU < @.***> wrote:

@.**** requested changes on this pull request.

Good work. There's still one open point here

On app.py https://github.com/ADORSYS-GIS/report-sscrap/pull/109#discussion_r1410726829 :

This is not a good python code. Please fix this

— Reply to this email directly, view it on GitHub https://github.com/ADORSYS-GIS/report-sscrap/pull/109#pullrequestreview-1757554780, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAETYIVJKHIYUUVJV4V3NYLYHCHTHAVCNFSM6AAAAABABGCIVWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJXGU2TINZYGA . You are receiving this because you commented.Message ID: @.***>

Blindspot22 commented 10 months ago

@AssahBismarkabah see, if you don't put their names, they might lightly not see it

Blindspot22 commented 10 months ago

I think it's now left to @ArmandMeppa to view if the changes are up to his expectations then approve it

AssahBismarkabah commented 10 months ago

hello @ArmandMeppa good morning sir please we your review is still pending on this PR

ValantineSuh commented 10 months ago

Thank you @Blindspot22 and @Koufan-De-King

Please Sir @ArmandMeppa we are waiting for your review