search

ADORSYS-GIS / report-sscrap

0 stars 0 forks source link

feature(global) specifying data to look for from through methods #86

Closed AssahBismarkabah closed 10 months ago

AssahBismarkabah commented 10 months ago

updated scrapping functionality and parameters

AssahBismarkabah commented 10 months ago

hello @stephane-segning yes sir using jupyter notebook since the user interface is not completed

AssahBismarkabah commented 10 months ago

good afternoon sir @stephane-segning based on the changes made on the branch when the pull request was already successful

AssahBismarkabah commented 10 months ago

so the scraping parameters where reconfigured based on the text and the images

AssahBismarkabah commented 10 months ago

good day sir @Stephane Segning Lambou @.***> trust you are doing well

the related ticket is closed because the ticket was already aproved and later on changes where being made on thesame ticket which leaded to aother pull request.

On Tue, Nov 28, 2023 at 9:34 AM Stephane SEGNING LAMBOU < @.***> wrote:

@.**** requested changes on this pull request.

How's it that the related ticket is closed @AssahBismarkabah https://github.com/AssahBismarkabah ?

— Reply to this email directly, view it on GitHub https://github.com/ADORSYS-GIS/report-sscrap/pull/86#pullrequestreview-1752320709, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAETYIRKU4SA3IBDRRIIVQTYGWOYNAVCNFSM6AAAAAA7Y3NMYKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJSGMZDANZQHE . You are receiving this because you were mentioned.Message ID: @.***>

stephane-segning commented 10 months ago

Ok, then re-open the ticket and please link it to it again, if needed

AssahBismarkabah commented 10 months ago

Done sir, and linked.

On Tue, Nov 28, 2023 at 1:59 PM Stephane SEGNING LAMBOU < @.***> wrote:

Ok, then re-open the ticket and please link it to it again, if needed

— Reply to this email directly, view it on GitHub https://github.com/ADORSYS-GIS/report-sscrap/pull/86#issuecomment-1829794721, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAETYIWQEMQAIMBKPC6FDRDYGXN43AVCNFSM6AAAAAA7Y3NMYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZG44TINZSGE . You are receiving this because you were mentioned.Message ID: @.***>

stephane-segning commented 10 months ago
Screenshot 2023-11-28 at 17 41 54

Nope

AssahBismarkabah commented 10 months ago

good morning sir @stephane-segning i reopened it already yesterday sir Screenshot from 2023-11-29 10-04-19

AssahBismarkabah commented 10 months ago

sir the related ticket was already closed

AssahBismarkabah commented 10 months ago

open now @stephane-segning sir

AssahBismarkabah commented 10 months ago

good morning sir trust you are doing well today reopened sir

On Tue, Nov 28, 2023 at 5:42 PM Stephane SEGNING LAMBOU < @.***> wrote:

Screenshot.2023-11-28.at.17.41.54.png (view on web) https://github.com/ADORSYS-GIS/report-sscrap/assets/26783557/115acc7d-c0ba-4ef9-afee-344b31b82e5d

Nope

— Reply to this email directly, view it on GitHub https://github.com/ADORSYS-GIS/report-sscrap/pull/86#issuecomment-1830271971, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAETYIQVTLNENVOXTE44EJ3YGYIADAVCNFSM6AAAAAA7Y3NMYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZQGI3TCOJXGE . You are receiving this because you were mentioned.Message ID: @.***>

AssahBismarkabah commented 10 months ago

Fixed! sir

On Fri, Dec 1, 2023 at 1:13 PM Stephane SEGNING LAMBOU < @.***> wrote:

@.**** requested changes on this pull request.

In app.py https://github.com/ADORSYS-GIS/report-sscrap/pull/86#discussion_r1410417499 :

app = Flask(name) +app.secret_key = 'your_secret_key' # Setting a secret key for flash messages

Why add this?

— Reply to this email directly, view it on GitHub https://github.com/ADORSYS-GIS/report-sscrap/pull/86#pullrequestreview-1757042609, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAETYIRIUPHCKNFXNWIUEDLYHHCWTAVCNFSM6AAAAAA7Y3NMYKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJXGA2DENRQHE . You are receiving this because you were mentioned.Message ID: @.***>

Blindspot22 commented 10 months ago

Fixed! sir … On Fri, Dec 1, 2023 at 1:13 PM Stephane SEGNING LAMBOU < @.> wrote: @*.*** requested changes on this pull request. ------------------------------ In app.py <#86 (comment)> : > app = Flask(name) +app.secret_key = 'your_secret_key' # Setting a secret key for flash messages Why add this? — Reply to this email directly, view it on GitHub <#86 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAETYIRIUPHCKNFXNWIUEDLYHHCWTAVCNFSM6AAAAAA7Y3NMYKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJXGA2DENRQHE . You are receiving this because you were mentioned.Message ID: @.>

@AssahBismarkabah include his name there, so it will be sent to him like so @stephane-segning