search

ADORSYS-GIS / wallet-vc-libs

1 stars 0 forks source link

Isolate storage library #1

Closed Awambeng closed 3 weeks ago

Awambeng commented 4 weeks ago

Refactor storage logic into a standalone library in a new repository for reusability

nitch2019 commented 4 weeks ago

@hugoib pls check the protection on this repo

hugoib commented 3 weeks ago

Added branch protection, after we set the structure of how many libraries will live in this repo, we will implement proper CI checks:

https://github.com/ADORSYS-GIS/wallet-vc-libs/issues/5https://github.com/ADORSYS-GIS/wallet-vc-libs/issues/5

hugoib commented 3 weeks ago

I reviewed, it looks good, tests are passing after adding typescript to the package.json

After we approve this:

https://github.com/ADORSYS-GIS/wallet-vc-libs/pull/6

Please adapt to that structure and I will review again before merging

hugoib commented 3 weeks ago

I reviewed again, looks good! Waiting for the pipeline to pass and then I will approve it.

hugoib commented 3 weeks ago

First merge this: https://github.com/ADORSYS-GIS/wallet-vc-libs/pull/7