search

ADRE9 / bunk-manager-mern

Building React Web App to manage attendance in a university.
https://salty-brook-29410.herokuapp.com/
MIT License
129 stars 67 forks source link

Create the Subject details page in React #146

Open Sanyam2000-dot opened 3 years ago

Sanyam2000-dot commented 3 years ago

Deliverables: Add the deliverables with their description here.

Screenshot (251) Screenshot (252)

Preeti2095 commented 3 years ago

I would like to work in this issue.

Sanyam2000-dot commented 3 years ago

Sure, Go ahead! In case you face any doubt please comment here only. Happy coding :)

Preeti2095 commented 3 years ago

Okay, Thank you.

Preeti2095 commented 3 years ago

Screenshot (73) i have done this much. To put the calendar i am planning to do it in card. i am having problem to put that cards for calendar. Please help me in that or any suggestion @Sanyam2000-dot .

ADRE9 commented 3 years ago

@Preeti2095 for now put the calendar aside and work on the rest of the page. Calendar will need another issue of level three. Just put a blank div for calendar with a gray color and a label as Calendar to specify that a calendar would be integrated there. And make sure you use exact colors.

Preeti2095 commented 3 years ago

Okay.

Preeti2095 commented 3 years ago

Hello @Sanyam2000-dot @ADRE9. I would like to make a pr to show what i have done till now so that i can further improve my code and i have few doubts also. So can i make the pr?

ADRE9 commented 3 years ago

It would be better if you can show us some of the screenshots. And after that you can make a PR so that we can review.@Preeti2095

Preeti2095 commented 3 years ago

this is what i have done @ADRE9 @Sanyam2000-dot Screenshot (74)

Sanyam2000-dot commented 3 years ago

@Preeti2095 This looks good but try to optimize it more according to the design given to you.

Preeti2095 commented 3 years ago

yes, i am doing that. One question how can i make the text ( BUNK MANAGER) and the logo(small tick mark sign) on same line?

Preeti2095 commented 3 years ago

UPDATE:-

Screenshot (75)

i want to ask how can i put progress bar like it will be connected to graph, right?

ADRE9 commented 3 years ago

For now just complete the the design and make sure you are using Material UI for the designs. Make the progress bar using this

Preeti2095 commented 3 years ago

i think it will be better if i use this then progress bar. What do you think @ADRE9?

Preeti2095 commented 3 years ago

I am waiting for your response @ADRE9 @Sanyam2000-dot.

ADRE9 commented 3 years ago

I am waiting for your response @ADRE9 @Sanyam2000-dot.

Go for it. Sorry for not responding. Had some commitments.

Preeti2095 commented 3 years ago

I am waiting for your response @ADRE9 @Sanyam2000-dot.

Go for it. Sorry for not responding. Had some commitments.

It's alright!

Preeti2095 commented 3 years ago

Update @ADRE9 @Sanyam2000-dot :- Screenshot (77)

Preeti2095 commented 3 years ago

It is pretty much done and just left with light mode and make it responsive. So for light mode shall I create a different page?

Preeti2095 commented 3 years ago

It is pretty much done and just left with light mode and make it responsive. So for light mode shall I create a different page?

?? @ADRE9 @Sanyam2000-dot

ADRE9 commented 3 years ago

It is pretty much done and just left with light mode and make it responsive. So for light mode shall I create a different page?

Light mode just needs it to be using theme. You don't need to create another Page. And yes make it responsive.

Preeti2095 commented 3 years ago

including theme is getting overwhelming kind of thing for me....can you see my code and guide me ahead?? i can't do ahead alone. Will be greatful for your guidance @ADRE9 @Sanyam2000-dot or any other project admins or anyone.

ADRE9 commented 3 years ago

Hey @Preeti2095 , we are at the moment pretty busy. Glad you are so interested in learning. I'll help you as soon as I get some time.

Preeti2095 commented 3 years ago

Ok sure.