search

ADSD-SoC-FPGA / Code

3 stars 11 forks source link

Use `systemd-modules-load` in place of custom driver-loading unit #11

Open LRitzdorf opened 7 months ago

LRitzdorf commented 7 months ago

NOTE: Merge only after #13!

This is here now, in case we want to merge it at some point!

Setup is pretty trivial — the only really new thing here is the need for a make modules_install invocation. I've added a Makefile target for that, and it's documented in the associated README as well.

If there's anything else that should go along with this (especially any textbook revision notes), feel free to push more commits to this branch prior to merging! Maintainers should have permission to do that.

Resolves #9

LRitzdorf commented 7 months ago

Good clarification points there, thanks!

tvannoy commented 7 months ago

I will test this when I get the chance. I don't have an NFS rootfs set up, nor do I plan on making one, but I will change the install path accordingly.

LRitzdorf commented 7 months ago

Please do! Also, for what it's worth, I've been using exactly this system since last semester 🙂

tvannoy commented 7 months ago

Well yeah, I don't doubt that it works, just want to verify as a matter of principle before merging.

LRitzdorf commented 7 months ago

One last change. Turns out that make variables aren't actually part of the environment — that is, setting INSTALL_MOD_PATH in the Makefile doesn't mean it becomes an environment variable for make's child processes.

@tvannoy This resolves the issue I mentioned earlier today

LRitzdorf commented 4 months ago

Let's delay this until #13 is merged, since its naming changes affect this PR.

LRitzdorf commented 4 months ago

Just rebased on top of #13, so this is to be merged only after that.

Also, note that the diff here will include all of #13's changes, until after that merge occurs.