Open LRitzdorf opened 6 months ago
This would be a better way to do this. I wouldn't worry about how it affects the textbook. I plan to have an update section on GitHub that would give updates by section/page number and give reasons why the update was implemented. These updates would then get folded into the next revision.
Thanks,
Ross
On Tue, Feb 20, 2024 at 5:50 PM Lucas Ritzdorf @.***> wrote:
Currently, this repo provides a custom systemd service and script (in examples/passthrough/linux/systemd/) to load our custom AD1939 and TPA613A2 drivers. This is perfectly functional, but systemd actually provides a built-in way to achieve this: systemd-modules-load.service https://www.freedesktop.org/software/systemd/man/latest/systemd-modules-load.service.html. This service is active by default, and reads files placed inside of /etc/modules-load.d/, loading any kernel modules named therein. See also: modules-load.d(5) https://www.freedesktop.org/software/systemd/man/latest/modules-load.d.html .
I've talked briefly about this with @tvannoy https://github.com/tvannoy, and it's not clear how significantly this change would affect the textbook content. If the impact turns out to be substantial, waiting to implement this until the next textbook revision may be warranted.
— Reply to this email directly, view it on GitHub https://github.com/ADSD-SoC-FPGA/Code/issues/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNDUXFV2WPJX7TRUUZQWTTYUVAHDAVCNFSM6AAAAABDSDXXJ6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DKNJVGYYDIMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
My only comment here, in terms of pedagogy, is that we need to ensure that students still learn to create a systemd service, perhaps to launch their program on boot. If we make sure that they write their own systemd service elsewhere, then I'm fine with using systemd-modules-load
.
Currently, this repo provides a custom systemd service and script (in
examples/passthrough/linux/systemd/
) to load our custom AD1939 and TPA613A2 drivers. This is perfectly functional, but systemd actually provides a built-in way to achieve this:systemd-modules-load.service
. This service is active by default, and reads files placed inside of/etc/modules-load.d/
, loading any kernel modules named therein. See also: modules-load.d(5).I've talked briefly about this with @tvannoy, and it's not clear how significantly this change would affect the textbook content. If the impact turns out to be substantial, waiting to implement this until the next textbook revision may be warranted.